[Sadykhzadeh]

Closes #153.

What this changes

Local shells are ended and reaped

LocalTerminal::child is now a LocalShell, a small wrapper around the portable-pty child that does the following on drop:

• Ends the shell. It sends portable-pty's kill(): SIGHUP on Unix, which is what closing a terminal window does, and TerminateProcess on Windows.
• Collects the exit status off the caller's thread. wait() runs on its own short-lived thread, so the async caller is never blocked, even by a shell that ignores SIGHUP.
• Leaves alone a shell that has already been collected. That is a shell whose exit try_wait has already reported, as reap_exited does. portable-pty signals the raw pid without checking, and once the exit is collected that pid may belong to an unrelated process.

Jobs the user detached from the shell (nohup, disown) are not touched, the same as in any terminal emulator.

The unit tests that called child.kill() by hand after every remove no longer need to. A new Linux test spawns /bin/sh, drops the terminal, and waits for /proc/<pid> to disappear. That only happens once the process has been reaped, so a zombie would fail it.

Unused plugins removed

tauri-plugin-os and tauri-plugin-process are no longer depended on or registered. os:default is no longer granted. This overlaps with #123 on the capability line, and whichever merges second resolves it trivially.

Test plan

• cargo test -p clavyn-desktop --locked (Linux, local): 108 + 2 passed, including dropping_a_terminal_ends_and_reaps_its_shell
• cargo update -w --offline: lockfile drops the two plugins and their exclusive deps
• node scripts/verify/check-comments.mjs: ok
• CI (macOS and Windows builds; on Windows the drop path goes through TerminateProcess)

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[greptile-apps]

TREX could not finish testing

• Plan what to test
• Set up the environment and test the changed flows
• Post test results

[qodo-code-review]

PR Summary by Qodo

End and reap local shells when their tabs close

🐞 Bug fix ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• End local shells when their terminals close and reap them without blocking the caller.
• Avoid signaling shells whose exit status was already collected, preventing signals to reused
 process IDs.
• Remove unused OS and process plugins and the OS permission.

Diagram

graph TD
  Close["Tab closes"] --> Terminal["Terminal dropped"] --> Shell["LocalShell drop"] --> Reaped{"Already reaped?"}
  Reaped -- "No" --> Kill["Signal shell"] --> Wait["Background wait"]
  Reaped -- "Yes" --> Skip["Skip signal"]

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Shared reaper queue

• ➕ Could avoid starting a thread for every closed shell.
• ➖ A shell that ignores the termination signal could block a single worker indefinitely; a worker pool adds lifecycle and shutdown complexity.

Recommendation: Keep cleanup with the child-owning LocalShell and use a thread per uncollected shell. It covers removal and refused-creation paths without duplicating cleanup, while isolating potentially blocking waits. A shared reaper is only worth considering if thread creation becomes a measured concern.

Files changed (6) +77 / -87

Bug fix (2) +76 / -16

commands.rsWrap newly spawned local shells +1/-1

Wrap newly spawned local shells

• Constructs local terminals with LocalShell so closing or refusing a terminal triggers child cleanup.

desktop/src-tauri/src/commands.rs

state.rsOwn shell termination and reaping in LocalShell +75/-15

Own shell termination and reaping in LocalShell

• Adds a child wrapper that tracks exits collected by try_wait, signals only uncollected shells on drop, and waits on a separate thread. Updates terminal ownership tests to rely on automatic cleanup and adds a Linux test that checks the dropped shell disappears from /proc.

desktop/src-tauri/src/state.rs

Other (4) +1 / -71

Cargo.lockPrune unused plugin packages +0/-65

Prune unused plugin packages

• Removes both Tauri plugin packages and dependencies exclusive to them from the lockfile.

Cargo.lock

Cargo.tomlRemove OS and process plugin dependencies +0/-2

Remove OS and process plugin dependencies

• Drops the unused tauri-plugin-os and tauri-plugin-process dependencies from the desktop crate.

desktop/src-tauri/Cargo.toml

default.jsonRevoke unused OS capability +1/-2

Revoke unused OS capability

• Removes os:default from the main window's permissions.

desktop/src-tauri/capabilities/default.json

main.rsStop registering unused plugins +0/-2

Stop registering unused plugins

• Removes OS and process plugin initialization from the Tauri application builder.

desktop/src-tauri/src/main.rs

[qodo-code-review]

Code Review by Qodo