Repository navigation
Reject a closure move while a reference to that binding is still in scope. - #33
Merged
Merged
Conversation
…cope. An unused borrow ended at its let, so moving the owner into a closure compiled and left the pointer in the local. That move is now BorrowConflict. A use after the reference's last use, outside a closure, is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BorrowConflictwhile a&or&mutof that binding is still in scope, including a reference that is never read.Test plan
test_closure_unused_borrow_error.ionexpectsBorrowConflicttest_unwrap_after_borrow.ionexits 1test_closure_copy_after_borrow.ionexits 10cargo test --lib,cargo clippy -- -D warnings, andtest_runner.sh(544 passed)