Repository navigation
Claim channel slots on the success path - #31
Merged
Merged
Conversation
…lace. Programs that link the runtime must relink, and programs that import the map must be recompiled. Box allocation is an inline malloc so the C compiler can see it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elem_sizebytes on the success path. A pthread wait happens only when the buffer is full, empty, or disconnected, and only after the waiter is registered and the operation is retried. This impacts every program that links the runtime: relink with thision_runtime.c. Ion source is unchanged.HashMapprobes andfor_eachborrow slots withVec::get_ref.Vec::setruns only for the index that receives a new pair or a tombstone. This impacts programs that importstdlib/map.ion: recompile them.ion_box_allocandion_box_freearestatic inlinemallocandfreeinruntime/ion_runtime.h. This impacts C that called those symbols fromion_runtime.o: recompile that C against this header.Test plan
cargo testcargo clippy -- -D warningstests/test_runner.shHashMapinsert plus scan, andBoxnew/unwrap match the pre-change build