Repository navigation
Conversation
The icon-only close button rendered by `showClose` had no accessible name, so screen readers announced it as "button". It now carries aria-label="Close", matching Popover. CloseButton also dropped the data-testid it was given; it now passes its props through. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 4fa3b59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-6sjpndvmv-clickhouse.vercel.app Built from commit: |
Contributor
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dialog.Contentheader close button (rendered withshowClose) is icon-only and had no accessible name, so screen readers announced it as just "button". It now hasaria-label="Close", the same labelPopoveruses.CloseButtonreceiveddata-testid="click-dialog-close"but only acceptedonClose, so the test id never reached the DOM. It now passes its remaining props through toCrossButton, after the hardcodedaria-labelso consumers can override it.onCloseand closes the dialog.Links and tickets
None.
Good to know
data-testidare added.Checklist
Contribution
buildandbuild-storybookwork locallyRan
typecheck,lint,format,circular-dependency:check,test(911 passed),buildandstorybook:build. Visual tests were not run (no visual change). Not yet checked by hand in Storybook or with a screen reader.Accessibility
aria-labelChecked: WCAG 2.2 4.1.2 Name, Role, Value, through the unit test. Keyboard and vision behavior are unchanged and were not re-tested.
🤖 Generated with Claude Code