Skip to content

fix(Button): use the global focus ring on secondary, empty and danger - #1319

Closed
kanakkholwal wants to merge 1 commit into
ClickHouse:mainfrom
kanakkholwal:fix/button-focus-ring
Closed

kanakkholwal wants to merge 1 commit into
ClickHouse:mainfrom
kanakkholwal:fix/button-focus-ring

Conversation

@kanakkholwal

@kanakkholwal kanakkholwal commented Nov 19, 2026 •

Copy link
Copy Markdown

Description

  • Secondary, Empty and Danger now use --click-global-color-outline-default on :focus-visible, same as BaseButton and IconButton
  • Primary keeps its own ring (design call, see issue)

Links and tickets

Fixes #1305

Good to know

Visual snapshots for Button not regenerated locally (no Docker). CI will flag the intended focus diffs.

Checklist

  • Breaking changes? (add migration notes in changesets)
  • Visual changes? (specify in changesets)
  • Design review needed?

Note

Low Risk
CSS-only focus-outline token swap on three button variants with no logic or API changes.

Overview
Updates keyboard focus styling for Button variants secondary, empty, and danger so :focus-visible uses the shared token --click-global-color-outline-default instead of each variant’s stroke-active color.

Previously those outlines could disappear or fail contrast (below 3:1); they now match BaseButton’s focus ring. Primary is unchanged and still uses its variant-specific outline per design. A patch changeset documents the visual/accessibility fix for @clickhouse/click-ui.

Reviewed by Cursor Bugbot for commit 6f6c211. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6f6c211

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@XOP

XOP commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

please check for existing PRs
#1308

@XOP XOP closed this Nov 19, 2026
@XOP XOP added the duplicate This issue or pull request already exists label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Empty and Danger buttons show no visible focus ring, and Secondary's is under 3:1

2 participants