Repository navigation
fix(Button): use the global focus ring on secondary, empty and danger - #1319
Closed
kanakkholwal wants to merge 1 commit into
Closed
kanakkholwal wants to merge 1 commit into
kanakkholwal wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 6f6c211 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
please check for existing PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--click-global-color-outline-defaulton:focus-visible, same as BaseButton and IconButtonLinks and tickets
Fixes #1305
Good to know
Visual snapshots for Button not regenerated locally (no Docker). CI will flag the intended focus diffs.
Checklist
Note
Low Risk
CSS-only focus-outline token swap on three button variants with no logic or API changes.
Overview
Updates keyboard focus styling for
Buttonvariants secondary, empty, and danger so:focus-visibleuses the shared token--click-global-color-outline-defaultinstead of each variant’s stroke-active color.Previously those outlines could disappear or fail contrast (below 3:1); they now match BaseButton’s focus ring. Primary is unchanged and still uses its variant-specific outline per design. A patch changeset documents the visual/accessibility fix for
@clickhouse/click-ui.Reviewed by Cursor Bugbot for commit 6f6c211. Bugbot is set up for automated code reviews on this repo. Configure here.