Repository navigation
feat(Pagination): add pageNumberMode prop - #1315
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c28176a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EvandroLG
marked this pull request as ready for review
November 17, 2026 09:38
XOP
requested changes
Nov 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… called in text mode Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
XOP
self-requested a review
November 18, 2026 09:31
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-3x5q8agls-clickhouse.vercel.app Built from commit: |
Contributor
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pageNumberModeprop toPagination,'input'by default. With'text', the page number shows as text ("3 of 10") instead of an input, so the page changes only through the previous and next buttons.Checklist
Contribution
buildandbuild-storybookwork locallyAccessibility
aria-labelCovered by unit tests: by default the page number is an input, with the prop it's plain text and there's no input, and the previous and next buttons still change the page. With the prop there's one less Tab stop, and screen readers read the page number as text. The text uses the existing
Textcomponent and its tokens. Not done yet: a manual keyboard pass and the Storybook axe panel.Screenshots
New visual baselines for the
TextPageNumberstory (light and dark) are intests/display/pagination.spec.ts-snapshots/. The existing Pagination snapshots are unchanged.🤖 Generated with Claude Code
Note
Low Risk
Backward-compatible optional UI prop with default unchanged; limited to Pagination presentation and a11y behavior for consumers who opt into
'text'.Overview
Adds optional
pageNumberMode('input'|'text', default'input') toPagination, exported asPaginationPageNumberMode. With'text', the editableNumberFieldis replaced by formatted page text plus the existing “of N” label; a visually hidden “Page” prefix keeps screen readers announcing e.g. “Page 3”. Page changes in that mode happen only via prev/next;onPageNumberFocus/onPageNumberBlurare not used.Ships a
TextPageNumberStorybook story, unit tests (default input, text mode, sr-only label, button navigation), a minor changeset for@clickhouse/click-ui, and a new visual-regression variant for text-page-number.Reviewed by Cursor Bugbot for commit c28176a. Bugbot is set up for automated code reviews on this repo. Configure here.