Skip to content

ci(publish): push the release bump and tag with the click-ui-automation App - #1307

Merged
XOP merged 4 commits into
mainfrom
ci/click-ui-automation-app
Nov 19, 2026
Merged

XOP merged 4 commits into
mainfrom
ci/click-ui-automation-app

Conversation

@Flipmonster

@Flipmonster Flipmonster commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

What: the publish job's release steps now use a short-lived click-ui-automation GitHub App token instead of PAT_TOKEN: the version-bump commit to main, the tag push, and the release-notes edit. The job runs in a new automation environment, which holds the App key and allows only main and v* tags. Canary mode doesn't mint a token.

Why: click-ui main is moving to required PR + review. It was dropped to level-1 because this push used a PAT. The App is on the org bypass list. A personal access token can't be.

Check: a release dispatched from a branch other than main, or a tag without the v prefix, won't get the key. Tell us if you use either.

Before merge: Security applies the bypass (ClickHouse/security-integrations#6405). Please don't merge until then.

🤖 Generated with Claude Code


Note

Medium Risk
Changes how production releases authenticate and push to protected branches; misconfiguration of the App or environment could block releases or grant write access.

Overview
Release publishing no longer uses PAT_TOKEN. The publish job runs in a new automation GitHub Environment, mints a short-lived click-ui-automation App token, and uses it for the release checkout, writing release notes, and (per existing release steps) pushing the version bump and tag—so automation can comply with required reviews on main.

A new “Guard - release from main only” step fails fast when a release is requested from a branch other than main, and the manual workflow input description states that releases build from main only.

docs/publish.md is updated to match: only maintainers create v* tags, v* tags cannot be deleted under org rules (delete the release only), and “start over” explains reusing an existing tag vs bumping the version.

Reviewed by Cursor Bugbot for commit 29f22d9. Bugbot is set up for automated code reviews on this repo. Configure here.

…on App

The release job's version-bump commit to main, the tag push and the
release-notes edit now use a short-lived click-ui-automation App token
instead of PAT_TOKEN. main is moving to required PR + review, and the App
is on the org bypass list; a personal access token cannot be. The job runs
in the `automation` environment, which holds the App key and admits main
and v* tags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 29f22d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Pass permission-contents (and permission-pull-requests where the job
opens or merges PRs) to create-github-app-token, so the token does not
inherit every permission of the installation (zizmor github-app audit).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Flipmonster
Flipmonster marked this pull request as ready for review November 18, 2026 09:43

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7575631. Configure here.

Comment thread .github/workflows/publish.yml Resolved
@XOP XOP added infra CI, workflows, scripts github_actions Pull requests that update GitHub Actions code labels Nov 18, 2026
The automation environment admits a run from main, but resolve and
publish then checked out whatever branch the dispatch input or the
release target named and ran its scripts with the App token. resolve
now refuses any branch other than main for a release.

app-id is deprecated in create-github-app-token; use client-id from the
new CLICK_UI_AUTOMATION_CLIENT_ID repository variable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@XOP
XOP self-requested a review November 18, 2026 15:22

@XOP XOP left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Flipmonster !

  • publish.yml:227: a run from main with branch=foo passes the gate, then runs foo’s scripts with the App token. Please reject anything but main in resolve for the release path.
  • publish.yml:218: app-id is deprecated. Please switch to client-id (needs a repo variable; I only have maintain).

The org tag floor refuses deleting or moving v* tags, and a new repo
ruleset lets only maintainers, admins and click-ui-automation create
them. Start over now keeps the tag: re-publish on it if main has not
moved, else use the next version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@workflow-authentication-public

Copy link
Copy Markdown
Contributor

Storybook Preview Deployed

✅ Preview URL: https://click-gvjsoynvl-clickhouse.vercel.app

Built from commit: 678533b41fab9038c3b1c3498aa97d90d2d1a0fe

@workflow-authentication-public

Copy link
Copy Markdown
Contributor

Chromatic Storybook

Check Status Link
Storybook ✅ 671 stories published Open Storybook
UI Tests ✅ 671 tests unchanged Open build

Built from commit: 29f22d968aea734b2f8ecd19d660e153c5c04bd6 · Chromatic run

Statuses as of the end of the run. The build link shows the live review state.

@XOP XOP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@XOP
XOP requested a review from vineethasok November 19, 2026 09:21
@XOP
XOP merged commit 91e1955 into main Nov 19, 2026
11 checks passed
@XOP
XOP deleted the ci/click-ui-automation-app branch November 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code infra CI, workflows, scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants