Repository navigation
ci: Migrate from prettier to oxfmt - #3732
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
E2E Test Results✅ All tests passed • 470 passed • 1 skipped • 1289s
Tests ran across 4 shards in parallel. |
🟡 Tier 3 — StandardIntroduces new logic, modifies core functionality, or touches areas with non-trivial risk. Why this tier:
Additional context: touches background tasks or the delivery pipeline lightly (2 lines, under the 30-line bar for Tier 4), 2 file(s) in private internal-tooling packages, excluded from the line count Review process: Full human review — logic, architecture, edge cases. Stats
|
PR Review✅ No issues found. |
Deep ReviewFormatter migration (prettier → oxfmt): config swap, ✅ No critical issues found. 🟡 P2 — recommended
🔵 P3 nitpicks (2)
Reviewers (7): correctness, testing, maintainability, project-standards, previous-comments, agent-native, learnings-researcher. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
brandon-pereira
left a comment
There was a problem hiding this comment.
LGTM! Formatting works great!
Summary
This PR migrates the repo from prettier to oxfmt.
Why? Faster formats and format checks!
Editor setup: developers need the oxc VS Code extension instead of the prettier one.
How much faster?
Tradeoffs
oxfmt is still relatively new, and there are a few small formatting changes vs prettier, applied in this PR.
How to reproduce
Run the lint / format step (skip cache for a fair duration):
References