Repository navigation
fix(rag): make NaiveRAG generate from retrieved context - #7
Merged
Merged
Conversation
ChinaYiqun
marked this pull request as ready for review
July 29, 2026 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ChatServiceabstraction so the RAG pipeline can be tested without network calls;OpenAIChatServiceas the default OpenAI-compatible implementation;NaiveRAGfrom a demo-shaped chain into an actual RAG pipeline;EmbeddingService#getEmbeddings;[1],[2], etc.;parsering()as a deprecated compatibility alias for the correctly namedparsing()method;Root cause
The previous
NaiveRAG.LLMChat()ignored both the user query and retrieved chunks. It always sent the fixed prompt1+1 = ?to the model. The embedding phase also computed the query vector and discarded it, forcing the sorting phase to make a second provider call.User impact
The minimal pipeline now performs the behavior its name promises:
The full constructor supports dependency injection for alternative splitters, embedding models, and chat providers while the original two-argument constructor remains available.
Validation
CI runs all Maven tests. The new tests verify that: