Repository navigation
security: externalize credentials and add CI guardrails - #6
Merged
Merged
Conversation
ChinaYiqun
marked this pull request as ready for review
July 29, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Config.java;Config.*field API while resolving values from JVM system properties, then environment variables, then safe non-secret defaults;.env.exampleand ignores local environment/configuration files;Why
The public repository contained credential-like values and remote infrastructure passwords. Deleting them from the latest source does not revoke them or remove them from Git history, so they must be considered compromised. This PR prevents continued use of committed secrets and adds guardrails against reintroducing them.
Compatibility
Existing references such as
Config.API_KEY,Config.REDIS_HOST,Config.esUrl, andConfig.Jina_API_KEYremain available. Deployments can configure the project with environment variables or-DJVM properties without adopting a framework.Required owner action
After merge, rotate all affected provider and infrastructure credentials. Git history rewriting is optional cleanup and is not a replacement for rotation.
Validation
GitHub Actions runs:
bash scripts/check-no-hardcoded-secrets.sh mvn --batch-mode --no-transfer-progress test