Repository navigation
Conversation
pt_arc and arc_pt chose between the two tangency points by comparing angles already wrapped into [0, 2pi), which picks the wrong one whenever the pair straddles the seam. The march runs counter-clockwise, so the circle must lie left of the supporting segment - and that is always the first point for pt_arc and the second for arc_pt.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2109 +/- ##
==========================================
- Coverage 95.81% 95.80% -0.01%
==========================================
Files 30 30
Lines 9599 9594 -5
Branches 1441 1441
==========================================
- Hits 9197 9192 -5
Misses 247 247
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
added 2 commits
October 12, 2026 17:56
The march stopped as soon as it came back to the start entity, but an arc can lie on the hull more than once - a large circle between two smaller ones does. Keep going instead; the hull is closed when the march stands on the start and every remaining candidate lies behind it. Fixes CadQuery#931.
kimstik
marked this pull request as ready for review
October 12, 2026 16:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes hull() returning wrong hulls on ordinary input - roughly one random circle-and-line set in four.
The march picked its supporting tangent by comparing wrapped angles and stopped on the first return to the start.
Both are heuristics that fail on valid input, and both are replaced by the condition they stood for.
The hull wire is now assembled in the order of the march, so a face built on it points the right way.
Follows #2100.
Fixes #931. Fixes #1891.
This one is the second of three in a hull fix PR series. The arc related rework is expected to follow.