Skip to content

feat: 상품 이미지 상한 5 → 6장 - #517

Merged
chanwoo7 merged 1 commit into
developfrom
feat/product-image-limit-6
Oct 5, 2026
Merged

chanwoo7 merged 1 commit into
developfrom
feat/product-image-limit-6

Conversation

@chanwoo7

@chanwoo7 chanwoo7 commented Oct 5, 2026

Copy link
Copy Markdown
Member

요약

  • 상품 이미지 상한을 5장에서 6장으로 올립니다. 판매자 앱 상품 등록 시안의 이미지 드롭존이 '이미지 추가 (0/6)'로 최대 6장을 받아, 사용자 결정(2026-10-06)으로 BE를 시안에 맞췄습니다.
    • MAX_PRODUCT_IMAGES 5 → 6(product-seller.constants.ts)
    • 이 상수를 쓰는 곳은 sellerAddProductImage의 개수 검사 하나입니다.
    • PRODUCT_IMAGE_LIMIT_EXCEEDED 메시지는 { max }로 렌더되므로 '상품 이미지는 최대 6장까지 등록할 수 있습니다.'로 함께 바뀝니다.
  • 관리자 경로는 영향이 없습니다. 관리자 상품 API에는 이미지 추가가 없고 조회(imageUrls)만 있어 상한을 쓰지 않습니다.
  • SDL·Prisma 변경은 없습니다. 상한 문구가 SDL description에 없어 FE codegen 산출물도 바뀌지 않습니다.

FE 영향

  • 판매자 앱: 상품 등록 작업 브랜치(feat/products-create)의 드롭존 상한(draft-form.ts의 MAX_IMAGES = 6)이 이 PR로 BE와 같아집니다.
    • 이 PR이 운영에 나가기 전에는 6장째 sellerAddProductImage가 PRODUCT_IMAGE_LIMIT_EXCEEDED로 거절됩니다.
  • 구매자 FE(caquick-fe-v2): 영향이 없습니다.
    • sellerAddProductImage·상한 상수를 쓰지 않고, 상품 상세는 product.images를 개수 제한 없이 그대로 그립니다.
  • 관리자 FE: 상품 상세가 imageUrls를 개수 제한 없이 나열하므로 영향이 없습니다.

테스트

  • product-seller-image.service.spec의 상한 케이스를 새 경계로 바꿨습니다.
    • 5장을 시드한 뒤 6장째 추가는 성공, 7장째는 PRODUCT_IMAGE_LIMIT_EXCEEDED
    • 메시지에 최대 ${MAX_PRODUCT_IMAGES}장까지가 들어가고, 거절 뒤 건수가 MAX_PRODUCT_IMAGES(6)로 유지됨
  • 반증: 상수만 5로 되돌리면 6장째 추가에서 PRODUCT_IMAGE_LIMIT_EXCEEDED가 나며 새 경계 케이스가 실패함을 확인하고 되돌렸습니다(시드는 리터럴 5장이라 상수 변경을 따라가지 않습니다).
  • 관련 spec 4개(이미지 서비스·판매자 상품 resolver·상품 repository·에러 카탈로그)를 돌렸습니다.
    • Test Suites 4 passed, Tests 226 passed
  • yarn docs:check·tsc --noEmit·변경 파일 eslint·prettier가 통과했습니다.

플랜 대조

플랜 항목 상태
상품 이미지 상한 6장(사용자 결정 2026-10-06) 한 것

판매자 앱 상품 등록 시안의 이미지 드롭존이 '이미지 추가 (0/6)'로 최대 6장을 받는다.
사용자 결정(2026-10-06)으로 BE 상한을 시안에 맞춤.

- MAX_PRODUCT_IMAGES 5 → 6. 이 상수를 쓰는 곳은 sellerAddProductImage 하나.
  관리자 경로는 이미지 추가가 없고 조회(imageUrls)만이라 영향 없음.
- PRODUCT_IMAGE_LIMIT_EXCEEDED 메시지는 { max }로 렌더되므로 '최대 6장'으로 함께 바뀜.
- SDL 변경 없음 — 상한 문구가 SDL description에 없음.
- 회귀 테스트 1건 교체: 6장째 추가 성공, 7장째 PRODUCT_IMAGE_LIMIT_EXCEEDED,
  메시지의 max, 건수 6 유지. 시드는 리터럴이라 상수만 5로 되돌리면 6장째 추가에서 실패(반증 확인).
@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: CaQuick/caquick-be/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0d8fc958-013d-4447-8782-2301eaa06ceb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T22:34:42.662583Z 2a6324e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

Unused exported types (1)
전체 리포트
Unused exported types (1)
RateLimitPolicy  type  src/global/rate-limit/index.ts:4:8

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

🩺 NestJS Doctor — 90/100 (Excellent)

진단 484건 (error 12).

Category error warning info
architecture 1 1 44
correctness 0 266 0
performance 0 36 28
schema 0 0 76
security 11 21 0
architecture / security 상위 항목
  • error architecture/architecture/no-manual-instantiation: Manual instantiation of 'OutboxRepository' detected. Use dependency injection instead.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'getJwks' has no @UseGuards() at class or method level.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 98.01% 10684/10901
🟢 Branches 92.94% 4065/4374
🟢 Functions 97.53% 2132/2186
🟢 Lines 98.58% 9720/9860

Test suite run success

4236 tests passing in 383 suites.

Report generated by 🧪jest coverage report action from 2a6324e

@chanwoo7
chanwoo7 merged commit 38b4324 into develop Oct 5, 2026
17 checks passed
@chanwoo7
chanwoo7 deleted the feat/product-image-limit-6 branch October 5, 2026 22:42
@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant