Repository navigation
To try and resolve #1233 - #1249
Merged
Merged
To try and resolve #1233 #1249
Conversation
change ABNF to disallow things like `ssvc/`, update the python pattern and the test cases accordingly. use a simplified ABNF rule for readablity, because `[ 1*elem ]` equals `*elem` and whitespace after braces is not necessary (and not always used in the file). resolve CERTCC#1233
sei-vsarvepalli
force-pushed
the
fix-1233
branch
from
September 17, 2026 14:41
a578b72 to
0e0c154
Compare
sei-vsarvepalli
force-pushed
the
fix-1233
branch
from
September 17, 2026 15:40
ffcde25 to
7f303df
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workflow checkout configuration can prevent doctools updates from being pushed, and the documented ssvc/ behavior is inconsistent with its test.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR tightens namespace extension validation, regenerates related schemas and regexes, updates tests, and adjusts the doctools workflow.
Changes:
- Clarifies namespace extension grammar and validation.
- Updates generated schemas, registry data, and tests.
- Revises workflow checkout and action configuration.
File summaries
| File | Summary |
|---|---|
src/test/test_namespaces_pattern.py |
Tests bare ssvc/ as invalid; description requires clarification. |
src/ssvc/utils/ssvc_namespace_pattern.abnf |
Updates namespace extension grammar. |
src/ssvc/utils/namespace_patterns.py |
Updates generated namespace regex logic. |
data/schema/v2/SsvcObjectRegistry_2_0_0.schema.json |
Updates generated namespace validation patterns. |
data/schema/v2/SelectionList_2_0_0.schema.json |
Updates generated namespace validation patterns. |
data/schema/v2/DecisionTable_2_0_0.schema.json |
Updates generated namespace validation patterns. |
data/schema/v2/DecisionPointGroup_2_0_0.schema.json |
Updates generated namespace validation patterns. |
data/schema/v2/DecisionPoint_2_0_0.schema.json |
Updates generated namespace validation patterns. |
data/json/ssvc_object_registry.json |
Refreshes registry metadata. |
.github/workflows/run_doctools.yml |
Checkout ref must preserve the PR head branch for subsequent pushes. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ahouseholder
approved these changes
Sep 17, 2026
ahouseholder
left a comment
Contributor
There was a problem hiding this comment.
Assuming and/or based on the "expect fail ssvc/ test passing, I'm okay with this change. The trailing slash was unintended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the namespace extension pattern logic and its documentation to clarify the handling of language extensions, especially around empty language extensions and their valid forms. It also adjusts tests and workflow configuration for better correctness and coverage. The most important changes are outlined below:
Namespace extension pattern logic and documentation:
ssvc_namespace_pattern.abnf) and Python regex (namespace_patterns.py) to clarify and correct the rules for namespace extensions, distinguishing between empty language extensions and BCP-47 language codes, and specifying the valid forms for extension segments. [1] [2]Test coverage improvements:
test_namespaces_pattern.pyto remove an invalid case (x_example.test#test/) and add an invalid case (ssvc/) for empty language extensions, ensuring the tests align with the updated pattern rules. [1] [2]Workflow configuration:
run_doctools.yml) to check out the correct repository and commit SHA for pull requests, improving CI reliability and correctness.