Repository navigation
feat: add manual cancellation for queries and mutations - #49
Merged
Merged
Conversation
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cancel()API so callers can abort in-flight query or mutation requests and immediately reset loading state.AbortControllersignals with Axios so cancellation integrates with existing browser/Fetch semantics.Description
AbortControllerfor queries and mutations and wired requestsignalinto Axios requests insrc/core/client.ts.isCanceledErrorhelper to detect canceled requests and early-return to avoid invoking error handlers, and updated error handling accordingly.src/core/types.tsto includecancel: () => voidonQueryResultandMutationResultand returnedcancelfrom hook factories.tests/client-runtime.test.tsto cover exposingcancel()for queries and mutations and to verify canceled requests do not call error handlers.Testing
npm test(Vitest); all tests passed (114 testspassed).npm run build; the build completed successfully.Codex Task