Initial address command implementation - #108
Open
Redstoner507 wants to merge 4 commits into
Open
Redstoner507 wants to merge 4 commits into
Redstoner507 wants to merge 4 commits into
Conversation
Zoriot
requested changes
Sep 19, 2026
|
|
||
| private boolean handleGetCommand(@NonNull Player player, String @NonNull [] args) { | ||
| if (!player.hasPermission(Permissions.ADDRESS_GET)) { | ||
| player.sendMessage(ChatHelper.getErrorComponent("You don't have the required %s to %s address.", "permission", |
Collaborator
There was a problem hiding this comment.
Please use Utils#sendNoPermissionMessage
|
|
||
| private boolean handleTeleportCommand(@NonNull Player player, String @NonNull [] args) { | ||
| if (!player.hasPermission(Permissions.ADDRESS_TELEPORT)) { | ||
| player.sendMessage(ChatHelper.getErrorComponent("You don't have the required %s to %s address.", "permission", |
Collaborator
There was a problem hiding this comment.
Please also use Utils#sendNoPermissionMessage
| return; | ||
| } | ||
|
|
||
| player.sendMessage(address); |
Collaborator
There was a problem hiding this comment.
I think smt like: <gray>Address: <white>{address} + make it possible to copy (with hover as explanation) would make more sense
Comment on lines
+130
to
+131
| player.sendMessage("Address found: " + address); | ||
| player.sendMessage("Teleporting... "); |
Collaborator
There was a problem hiding this comment.
Outputting the input again doesn't really make sense.
There are two option:
- Output the address/infos found by API
- Combine the messages and don't output that anyway. Smt like:
Address found, teleporting...- as btt info message
Comment on lines
+132
to
+137
| Bukkit.getScheduler().runTask( | ||
| BuildTeamTools.getInstance(), | ||
| () -> player.performCommand( | ||
| "tpll " + latitude + " " + longitude | ||
| ) | ||
| ); |
Collaborator
There was a problem hiding this comment.
Are you sure you need to schedule that on main thread?
| if (sender.hasPermission(Permissions.ADDRESS_TELEPORT)) list.add("teleport"); | ||
|
|
||
|
|
||
| return list.stream() |
Collaborator
There was a problem hiding this comment.
I think it would make sense to provide some examples for teleport
|
|
||
| String url = BASE_URL + "reverse?lat=" + coordinates.latitude() | ||
| + "&lon=" + coordinates.longitude() | ||
| + "&lang=en"; |
Collaborator
There was a problem hiding this comment.
I'm not completely sure what the best way is but outputting the address in the local language also sounds quite useful
| return true; | ||
| } | ||
|
|
||
| if (args[0].equalsIgnoreCase("get")) { |
Collaborator
There was a problem hiding this comment.
/address with no arguments crashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented random new address command (Issue #64)
Use of PhotonAPI for getting the closest address and getting an address location
(Will be replaced by Nominatim Api )
'/address get' will get the player the closest address
'/address teleport' will theport the player to the address entered