Repository navigation
ci(release): pass the App's Client ID as a secret - #13
Merged
Merged
Conversation
diffcop review✅ All good What we looked atRead release.yml after the change: the input moves from Read (1): Reviewed c80023c · 8s · 1 tool call · 18.1K input tokens (79% cached) · 249 output · ~$0.02 run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shared
bun-npm-releaseworkflow now takes BriansBot's Client ID as a secret (BrianEstrada/.github#3), matching theRELEASE_APP_CLIENT_IDsecret this repo already has. Until this merges,release.ymlreads avars.RELEASE_APP_CLIENT_IDthat doesn't exist, so releases fail.Approach
Pins the shared workflow to that merge commit (
27f39c4) and passes the Client ID undersecrets:.Verification
actionlintpasses.repo-defaults/apply.sh --checkfinds bothRELEASE_APP_*secrets here.