Skip to content

ci(release): pass the App's Client ID as a secret - #13

Merged
BrianEstrada merged 1 commit into
mainfrom
ci/release-client-id-secret
Oct 11, 2026
Merged

BrianEstrada merged 1 commit into
mainfrom
ci/release-client-id-secret

Conversation

@BrianEstrada

Copy link
Copy Markdown
Owner

Why

The shared bun-npm-release workflow now takes BriansBot's Client ID as a secret (BrianEstrada/.github#3), matching the RELEASE_APP_CLIENT_ID secret this repo already has. Until this merges, release.yml reads a vars.RELEASE_APP_CLIENT_ID that doesn't exist, so releases fail.

Approach

Pins the shared workflow to that merge commit (27f39c4) and passes the Client ID under secrets:.

Verification

actionlint passes. repo-defaults/apply.sh --check finds both RELEASE_APP_* secrets here.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

diffcop review

✅ All good

What we looked at

Read release.yml after the change: the input moves from with: to secrets:, and the shared-workflow SHA is pinned. I couldn't inspect the external workflow, so I couldn't check its input names or the pinned SHA.

Read (1): .github/workflows/release.yml


Reviewed c80023c · 8s · 1 tool call · 18.1K input tokens (79% cached) · 249 output · ~$0.02 run

@BrianEstrada
BrianEstrada merged commit b2fe76f into main Oct 11, 2026
2 checks passed
@BrianEstrada
BrianEstrada deleted the ci/release-client-id-secret branch October 11, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant