Repository navigation
ci: skip the review on Renovate PRs and use the shared Renovate preset - #12
Merged
Merged
Conversation
diffcop review✅ All good What we looked atI read the workflow and the diff. The author-based skip condition is valid and holds on every push to a Renovate branch. I could not read the external shared Renovate preset, so I could not check the description's claims about it. Read (1): Searched (1): Reviewed e060a5a · 14s · 2 tool calls · 19.1K input tokens (76% cached) · 847 output · ~$0.03 run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Renovate pushes its branches to this repo, so its PRs ran
review.ymlwith the Claude secrets in the environment while running diffcop with the PR's updated dependencies. A hijacked npm release could read them.Approach
review.ymlskips PRs opened byrenovate[bot], next to the existing fork check. It checks the PR's author, not the pusher, so it holds on every push to a Renovate branch..github/renovate.jsonnow extends the sharedgithub>BrianEstrada/.githubpreset. It's this repo's old config (config:recommended,chorecommits, pinned action digests) plus a 3-dayminimumReleaseAgefor npm releases, so a bad version is likely pulled before Renovate proposes it.Verification
actionlintpasses.renovate-config-validator --strictpasses on the shared preset.