Skip to content

ci: skip the review on Renovate PRs and use the shared Renovate preset - #12

Merged
BrianEstrada merged 1 commit into
mainfrom
ci/renovate-hardening
Oct 11, 2026
Merged

BrianEstrada merged 1 commit into
mainfrom
ci/renovate-hardening

Conversation

@BrianEstrada

Copy link
Copy Markdown
Owner

Why

Renovate pushes its branches to this repo, so its PRs ran review.yml with the Claude secrets in the environment while running diffcop with the PR's updated dependencies. A hijacked npm release could read them.

Approach

  • review.yml skips PRs opened by renovate[bot], next to the existing fork check. It checks the PR's author, not the pusher, so it holds on every push to a Renovate branch.
  • .github/renovate.json now extends the shared github>BrianEstrada/.github preset. It's this repo's old config (config:recommended, chore commits, pinned action digests) plus a 3-day minimumReleaseAge for npm releases, so a bad version is likely pulled before Renovate proposes it.

Verification

  • actionlint passes.
  • renovate-config-validator --strict passes on the shared preset.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

diffcop review

✅ All good

What we looked at

I read the workflow and the diff. The author-based skip condition is valid and holds on every push to a Renovate branch. I could not read the external shared Renovate preset, so I could not check the description's claims about it.

Read (1): .github/workflows/review.yml

Searched (1): .github/**


Reviewed e060a5a · 14s · 2 tool calls · 19.1K input tokens (76% cached) · 847 output · ~$0.03 run

@BrianEstrada
BrianEstrada merged commit e5d029c into main Oct 11, 2026
2 checks passed
@BrianEstrada
BrianEstrada deleted the ci/renovate-hardening branch October 11, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant