Skip to content

Fix: Profile and WiFi search timer #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 4 commits into from
Oct 21, 2026
Merged

Fix: Profile and WiFi search timer #3638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c3527a
Fix: Profile search filters while typing
BornToBeRoot Oct 21, 2026
8363a56
Fix: WiFi connection status message hidden too early
BornToBeRoot Oct 21, 2026
a5d6d7d
Docs: Add PR link to changelog
BornToBeRoot Oct 21, 2026
6ce57c3
Chore: Remove obvious timer comments
BornToBeRoot Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Source/NETworkManager/ViewModels/ImportProfilesResultViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public string Search
field = value;

IsSearching = true;
_searchDispatcherTimer.Stop();
_searchDispatcherTimer.Start();

OnPropertyChanged();
Expand Down
1 change: 1 addition & 0 deletions Source/NETworkManager/ViewModels/ProfileHostViewModelBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public string Search
if (!_searchDisabled)
{
IsSearching = true;
_searchDispatcherTimer.Stop();
_searchDispatcherTimer.Start();
}

Expand Down
1 change: 1 addition & 0 deletions Source/NETworkManager/ViewModels/ProfilesViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ public string Search
if (!_searchDisabled)
{
IsSearching = true;
_searchDispatcherTimer.Stop();
_searchDispatcherTimer.Start();
}

Expand Down
9 changes: 7 additions & 2 deletions Source/NETworkManager/ViewModels/WiFiViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,7 +1120,8 @@ private void Connect()

var ssid = selectedNetwork.IsHidden ? instance.Ssid : selectedNetwork.AvailableNetwork.Ssid;

// Show status message
// Show status message (not hidden by the timer of a previous message)
_hideConnectionStatusMessageTimer.Stop();
IsConnecting = true;
ConnectionStatusMessage = string.Format(Strings.ConnectingToXXX, ssid);
IsConnectionStatusMessageDisplayed = true;
Expand Down Expand Up @@ -1166,6 +1167,7 @@ private void Connect()
ResourceTranslator.Translate(ResourceIdentifier.WiFiConnectionStatus, connectionResult));

// Hide message automatically
_hideConnectionStatusMessageTimer.Stop();
_hideConnectionStatusMessageTimer.Start();

// Update the Wi-Fi networks.
Expand All @@ -1179,7 +1181,8 @@ private void Connect()

var ssid = selectedNetwork.IsHidden ? instance.Ssid : selectedNetwork.AvailableNetwork.Ssid;

// Show status message
// Show status message (not hidden by the timer of a previous message)
_hideConnectionStatusMessageTimer.Stop();
IsConnecting = true;
ConnectionStatusMessage = string.Format(Strings.ConnectingToXXX, ssid);
IsConnectionStatusMessageDisplayed = true;
Expand All @@ -1203,6 +1206,7 @@ private void Connect()
ResourceTranslator.Translate(ResourceIdentifier.WiFiConnectionStatus, connectionResult));

// Hide message automatically
_hideConnectionStatusMessageTimer.Stop();
_hideConnectionStatusMessageTimer.Start();

// Update the Wi-Fi networks.
Expand Down Expand Up @@ -1241,6 +1245,7 @@ private async void Disconnect()
IsConnectionStatusMessageDisplayed = true;

// Hide message automatically
_hideConnectionStatusMessageTimer.Stop();
_hideConnectionStatusMessageTimer.Start();
}

Expand Down
5 changes: 5 additions & 0 deletions Website/docs/changelog/next-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ Release date: **xx.xx.2026**
## Bug Fixes

- Fixed changes to lists in the settings (e.g. query histories, port profiles, custom commands) not being saved if no other setting was changed in the same session. This happened since the settings are stored as JSON. [#3607](https://github.com/BornToBeRoot/NETworkManager/pull/3607)
- Fixed the profile search (profile list in the tools, **Profiles** settings and import result) filtering the profiles while still typing. The profiles are now filtered once after the user stopped typing, instead of every 750 ms after the first key press. [#3638](https://github.com/BornToBeRoot/NETworkManager/pull/3638)

**Firewall**

Expand Down Expand Up @@ -134,6 +135,10 @@ Release date: **xx.xx.2026**

- Fixed the query history of **IP Geolocation** being written to the history of **Whois** instead of its own. [#3607](https://github.com/BornToBeRoot/NETworkManager/pull/3607)

**WiFi**

- Fixed the connection status message (e.g. "Connecting to ...") being hidden too early, while still connecting, if a previous message (e.g. after connecting or disconnecting) was shown shortly before. Each message is now shown for 15 seconds. [#3638](https://github.com/BornToBeRoot/NETworkManager/pull/3638)

## Dependencies, Refactoring & Documentation

- Code cleanup & refactoring
Expand Down
Loading