Skip to content

fix(build): propagate source discovery parse errors - #201

Merged
Arvolear merged 2 commits into
BlockstreamResearch:devfrom
brenorb:fix/source-discovery-errors
Nov 10, 2026
Merged

Arvolear merged 2 commits into
BlockstreamResearch:devfrom
brenorb:fix/source-discovery-errors

Conversation

@brenorb

@brenorb brenorb commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

When a configured .simf file cannot be parsed, simplex build currently warns and exits successfully. A malformed-only project publishes empty metadata; a mixed project publishes only its valid contracts. Callers therefore receive a false-green build result.

Propagate the source path and parser diagnostic as BuildError::SourceParse, so discovery fails before artifact generation. Every matched source must parse; valid helpers without main remain excluded. Existing artifacts stay intact when discovery fails.

Fixes #175.

Validation:

  • Reproduced malformed-only and mixed-source false successes on upstream a1bf060 in fresh disposable projects.
  • Added four real CLI regressions. Before the fix, the two malformed-source cases fail and both repaired/helper controls pass. After the fix, all four pass, including preservation of previous metadata and the absence of newly generated partial bindings.
  • cargo test --locked --offline -p smplx-build -p smplx-cli: 50 tests pass.
  • cargo clippy --locked --offline -p smplx-build -p smplx-cli --all-targets -- -D warnings, cargo fmt --all --check, and the build crate's --no-default-features check pass.
  • Independent agent review found no blocking issue. Full workspace and fixture checks run in CI.

Written by Codex.

@brenorb
brenorb requested a review from Arvolear as a code owner November 5, 2026 07:37

@Arvolear Arvolear left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear
Arvolear changed the base branch from master to dev November 10, 2026 15:29
@Arvolear
Arvolear merged commit e8a2ae9 into BlockstreamResearch:dev Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simplex build silently skips parser failures during source discovery and exits successfully

2 participants