Repository navigation
fix(build): propagate source discovery parse errors - #201
Merged
Arvolear merged 2 commits intoNov 10, 2026
Merged
Conversation
Fixes BlockstreamResearch#175. Written by Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a configured
.simffile cannot be parsed,simplex buildcurrently warns and exits successfully. A malformed-only project publishes empty metadata; a mixed project publishes only its valid contracts. Callers therefore receive a false-green build result.Propagate the source path and parser diagnostic as
BuildError::SourceParse, so discovery fails before artifact generation. Every matched source must parse; valid helpers withoutmainremain excluded. Existing artifacts stay intact when discovery fails.Fixes #175.
Validation:
a1bf060in fresh disposable projects.cargo test --locked --offline -p smplx-build -p smplx-cli: 50 tests pass.cargo clippy --locked --offline -p smplx-build -p smplx-cli --all-targets -- -D warnings,cargo fmt --all --check, and the build crate's--no-default-featurescheck pass.Written by Codex.