Repository navigation
Conversation
Member
|
This is too complicated and overengineered for a public example. It doesn't show Simplex in the best light. A lot of complexity can be removed by making covenant public keys as arguments (instead of hardcoding them to G, 2G, 3G), and following the regular |
schoen
force-pushed
the
feat/last-will-demo
branch
from
October 1, 2026 01:46
57a5e5d to
5cd0789
Compare
Contributor
Author
|
Hi @Arvolear, I've attempted to do that here. Could you have another look at this version? |
Arvolear
reviewed
Oct 2, 2026
Contributor
Author
|
@Arvolear Hopefully now somewhat better idiomaticity and use of the SDK throughout these tests. |
schoen
force-pushed
the
feat/last-will-demo
branch
2 times, most recently
from
October 11, 2026 06:14
9458406 to
7d6c0c8
Compare
Contributor
Author
|
Some fixes for the upstream 0.1.0 release (API change and a merge conflict), and also Note that this still adds a public wasm wrapper for |
Arvolear
reviewed
Oct 12, 2026
| [dependencies] | ||
| smplx-std = { path = "../../crates/simplex" } | ||
|
|
||
| anyhow = { version = "1.0.101" } |
Member
There was a problem hiding this comment.
Suggested change
| anyhow = { version = "1.0.101" } | |
| anyhow = { version = "1.0.104" } |
Arvolear
reviewed
Oct 12, 2026
| smplx-std = { path = "../../crates/simplex" } | ||
|
|
||
| anyhow = { version = "1.0.101" } | ||
| bitcoin_hashes = { version = "0.14" } |
Member
There was a problem hiding this comment.
This one is probably not needed anymore.
Arvolear
reviewed
Oct 12, 2026
| /// Returns an error if the transaction cannot be blinded or signed, if a witness cannot be injected | ||
| /// at the requested path, or if a covenant input does not execute. | ||
| #[wasm_bindgen(js_name = signTransaction)] | ||
| pub fn sign_transaction(&self, builder: &TransactionBuilder) -> Result<SignedTransaction, JsError> { |
Member
There was a problem hiding this comment.
Let's do this change in a separate PR. Otherwise, this one has to go in the dev branch.
Arvolear
reviewed
Oct 12, 2026
Arvolear
reviewed
Oct 12, 2026
| the fee and continuation outputs swapped. A change target cannot produce | ||
| those shapes, because Simplex always appends change first and fee second, | ||
| so those tests list their outputs directly and sign with `Signer::sign_tx`, | ||
| which appends nothing. |
Member
There was a problem hiding this comment.
Suggested change
| which appends nothing. | |
| which doesn't append anything. |
This uses the old `Either` style instead of the experimental `enum` version, because `enum` currently doesn't work under Simplex. The tests add some detailed information about what they're trying to accomplish and what happened, visible when they're run with `simplex test -v` In addition to learning more about Simplex, new users will understand a little more about Simplicity covenants.
Instead of hard-coding privkeys 1, 2, 3 and writing new signer logic, use proper wallet mnemonics and Simplex's built-in tools for this. Also tighten comments and narration.
- Program inputs take an Option<ProgramSignature>, so the spend path builds
ProgramSignature::new("INHERIT_OR_NOT").at_path(..) in place of
RequiredSignature::witness_with_path.
- A program that rejects a spend now surfaces as
SignerError::Program(ProgramError::ProgramExecution { .. }), which the
local-rejection tests match on.
- UTXO::amount() returns a Result, so the lifecycle test propagates it.
- Signed transactions are extracted with .extract_tx().
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Derived from examples/basic/Cargo.lock, so the example resolves to the same dependency versions as the rest of the workspace, including the pinned proptest 1.12.0. Only the root package entry differs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
schoen
force-pushed
the
feat/last-will-demo
branch
from
November 12, 2026 20:34
7d6c0c8 to
bc4982a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the old
Eitherstyle instead of the experimentalenumversion, becauseenumcurrently doesn't work under Simplex.The tests add some detailed information about what they're trying to accomplish and what happened, visible when they're run with
simplex test -vIn addition to learning more about Simplex, new users will understand a little more about Simplicity covenants.