Repository navigation
Conversation
Written by Codex.
Use the 0.2.0 Scenario API in a complete P2pk fuzz example and make the ordinary test prototype return unit without an added dependency. Both complete extracted blocks compile against the current SDK; no integration or fuzz run is claimed. Written by Codex.
Describe string and typed-object entries, provide a complete array literal, use the actual uppercase tuple witness name, and remove unsupported indexing. Narrow the type-coverage and alias-annotation claims to the supported forms. Validated through the pinned current SimplicityHL 0.9.0 compiler library parse/resolve/satisfy path, with six accepting and eight expected-rejection controls. No CLI, transaction, or signature verification is claimed. Written by Codex.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust developers reading the tooling and witness references need a clear route to the Simplex project workflow. The initialization guide suggests running
simplex initover an existing Rust project, although that command overwrites starter files, and its fuzz example uses the API removed in Simplex 0.2.0. The witness reference also describes typed objects as string-only entries and presents incomplete array values, an unsupported index expression, and a case-mismatched witness name.Name and link the Simplex workflow, explain that it uses the SimplicityHL compiler library directly, and label the manual CLI workflow. Show initialization into a new directory, its success output and existing-directory error, and the in-place overwrite warning. Replace the obsolete fuzz fragment with a complete starter-project P2pk
Scenarioexample, state its 0.2.0+ API requirement, and describe the current pre-executionspeccontract. Make the regular-test prototype return unit so it compiles with the starter's existing dependencies. Preserve the existing section anchors and manual references. Describe both witness-entry forms and their string-valued fields, use a complete four-elementu16array, and demonstrate uppercaseMYPAIRtuple destructuring. Remove the unsupported indexing claim and narrow coverage to common types and explicit built-in alias annotations.Validation:
a1bf060(Simplex 0.2.0).simplex init my_contractstarter and ransimplex build. The entire fuzz block, extracted directly from the page intotests/p2pk_fuzz.rs, compiles withcargo test --offline --no-run --test p2pk_fuzzagainst the current localsmplx-std0.2.0 source ata1bf060(only the proof manifest substitutes its local path; no extra dependency is required). This is compile-only validation on Rust 1.98.1: no node was started and the fuzz test was not executed. The old engine call, isolated with the same generated P2pk types, fails with E0107 (unwanted generic arguments) and E0061 (missingScenario).cargo test --offline --no-run --test regular_prototype. Its previousanyhow::Result<()>signature fails there with E0433 because the generated manifest doesn't declareanyhow. The unit-returning replacement needs no added dependency (the placeholder context parameter remains unused until test code is added). No integration test was executed.56e8f39, usingCompiledProgram::new → serde_json::from_str<UnresolvedValues> → resolve(witness_types) → CompiledProgram::satisfy: six accepted and eight rejected as expected. Accepted cases cover bare/typed/mixed entries, the final complete array, uppercase tuple destructuring and a bare custom-alias value. Expected rejections cover raw JSON numbers/booleans, a numeric typed value, the old truncated array, wrong array length, unsupported[0], the old lowercase witness name, and a typed custom alias. The typed built-inDistanceexample is accepted. Final extracted page examples match these fixtures. This checks parsing, witness typing and population; thesimcCLI frontend, transaction execution and signature verification were not exercised..github/documentation-review.md. Fresh full reviews cover the exact final Simplex page (132 lines) and witness page (232 lines), all 13 criteria and all 13 formatting rules per page. The final witness review independently checks all 10 JSON blocks, 17 fences, and the 14 compiler-library outcomes; it found no introduced correctness or formatting failure. Its update preserves the other three review sections and source hashes.Whole-page documentation screening (including inherited issues):
simplex.mdtoolchain.mdwallet.mdwitness-format.mdThis PR remains a draft because the whole-page screening retains those pre-existing issues. It proposes the bounded workflow, initialization, test API, and witness-format corrections for review. Source and compile checks cover the changed examples and claims; they do not establish runtime test success or validate every historical claim on the four pages against the current SDK.
Written by Codex.