Skip to content

chore: add pinned Nix devShell - #409

Open
lcovar wants to merge 1 commit into
masterfrom
chore/nix-devshell
Open

lcovar wants to merge 1 commit into
masterfrom
chore/nix-devshell

Conversation

@lcovar

@lcovar lcovar commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Add a default Nix devShell for Node.js 24.11.0, Rust nightly 2025-10-23, and the WebAssembly build tools across Darwin and Linux.

Document setup and wasm-ton verification, including the generated WASM prerequisite for the npm test suite.

Verified Rust parser tests (2 passed), WASM build, npm tests (39 passed), and the TypeScript build.

Ticket: BTC-0

Add a default Nix devShell for Node.js 24.11.0, Rust nightly 2025-10-23, and the WebAssembly build tools across Darwin and Linux.

Document setup and wasm-ton verification, including the generated WASM prerequisite for the npm test suite.

Verified Rust parser tests (2 passed), WASM build, npm tests (39 passed), and the TypeScript build.

Ticket: BTC-0
@lcovar
lcovar requested a review from a team as a code owner September 25, 2026 16:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T16:37:01.765482Z 759b216 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 759b216c60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread flake.nix
Comment on lines +40 to +44
rustToolchain
pkgs.binaryen
pkgs.gnumake
pkgs.wasm-pack
];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Provide a WASM-capable compiler in the Darwin shells

On a clean aarch64-darwin system without Homebrew, this shell provides neither LLVM nor brew, so the package Makefiles fall back to Apple Clang, which they explicitly note lacks the wasm32-unknown-unknown target. Builds requiring C compilation, such as wasm-bip32 through secp256k1-sys, therefore fail despite Darwin being advertised as supported; include a WASM-capable Clang/LLVM toolchain and configure CC/AR from it.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant