Skip to content

fix(statics): remove dup canton entry in networkFeatureMapForTokens - #9895

Merged
biwwy0 merged 1 commit into
masterfrom
WCN-2992/remove-duplicate-canton-entry-blocking-the-statics-build
Oct 6, 2026
Merged

fix(statics): remove dup canton entry in networkFeatureMapForTokens#9895
biwwy0 merged 1 commit into
masterfrom
WCN-2992/remove-duplicate-canton-entry-blocking-the-statics-build

Conversation

@danielpeng1

@danielpeng1 danielpeng1 commented Oct 5, 2026 •
edited by prajwalu142
Loading

Copy link
Copy Markdown
Contributor

Removes a duplicate canton key in networkFeatureMapForTokens that broke the statics build on master.

  • Delete the second canton: CANTON_TOKEN_FEATURES entry; the two came from separate PRs that merged cleanly into a duplicate
  • Additionally adds back hteth:tgku and hteth:stzamakms entries which were removed by the bot pr
  • Unblocks CI on feat(statics): add bip44CoinType per coin family #9882, which is currently blocked by this build failure
  • Tests: none added; the TypeScript compiler already rejects duplicate keys, and the statics build, typecheck, lint and format checks pass

Ticket: WCN-2992

@danielpeng1 danielpeng1 self-assigned this Oct 5, 2026
@linear-code

linear-code Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

WCN-2992

@github-actions

github-actions Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@danielpeng1
danielpeng1 marked this pull request as ready for review October 6, 2026 05:27
@danielpeng1
danielpeng1 requested a review from a team as a code owner October 6, 2026 05:27
at31416
at31416 previously approved these changes Oct 6, 2026
View reviewed changes
@danielpeng1

danielpeng1 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

I believe it's normal that the Audit API Spec continues failing, as the comparison to the merge base is master which contains the duplicate entry.

The failing test is due to hteth:stzamakms (and hteth:tgku) being removed from AMS in this PR #9826 - worth double-checking that

@prajwalu142
fix(statics): remove dup canton entry
ab08ecb 
Additionally add hteth:tgku and hteth:stzamakms
which were removed

Ticket: WCN-2992
@prajwalu142
prajwalu142 force-pushed the WCN-2992/remove-duplicate-canton-entry-blocking-the-statics-build branch from 8afc249 to ab08ecb Compare October 6, 2026 06:11
@biwwy0
biwwy0 merged commit d0f687a into master Oct 6, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukeshsp mukeshsp mukeshsp approved these changes
@biwwy0 biwwy0 biwwy0 approved these changes
@at31416 at31416 at31416 left review comments

Assignees

@danielpeng1 danielpeng1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danielpeng1 @mukeshsp @biwwy0 @at31416 @prajwalu142