feat(sdk-core): forward isWalletConnectTx through TSS prebuild path - #9888
Merged
nvjsr merged 1 commit intoOct 5, 2026
Merged
Conversation
Surface the client-supplied WalletConnect marker through PrebuildTransactionWithIntentOptions and PopulatedIntent so that wallet-platform can classify txChannel.connector = 'walletconnect' even on wallets that lack the enableWalletConnect flag. Previously both the case 'transfer' field list in prebuildTransactionTss and the EVM payment return in populateIntent silently dropped isWalletConnectTx before it reached body.intent. Ticket: DEFI-1013
Contributor
Contributor
|
|
venkateshv1266
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isWalletConnectTx?: booleantoPrebuildTransactionWithIntentOptionsandPopulatedIntentinbaseTypes.tsisWalletConnectTxinwallet.tscase'transfer'field list (prebuildTransactionTss)isWalletConnectTxinmpcUtils.tspopulateIntentEVM payment/transferToken/fillNonce returnContext
wallet-platform's
resolveEvmIsWalletConnectTxreadsintent.isWalletConnectTxto stamptxChannel.connector = 'walletconnect'on WalletConnect transactions that originate from wallets without theenableWalletConnectflag. Without this SDK change, the client-supplied marker was silently dropped at two explicit field whitelists before reachingbody.intent, making the wallet-platform fix in bitgo-microservices#63275 inert.Ticket: DEFI-1013
Test plan
npx tsc --noEmitinmodules/sdk-core)isWalletConnectTx: truethrough to wallet-platform intent after SDK beta publish and bump in downstream repos