fix(sdk-core): allow disabletoken in sendTokenEnablement guard - #9854
Merged
Merged
Conversation
prebuildTransactionTxRequests gained a 'disabletoken' case in f9ce83d (wire disabletoken prebuild intent for Canton), so prebuildTransaction succeeds for Canton disable-token flows. But sendTokenEnablement's validation guard still only allow-listed buildParams.type 'enabletoken'/'enableMpt', so sendTokenEnablements (and the retail-web disable-token UI, which calls it) threw 'Invalid build of token enablement.' immediately after a successful prebuild. Adds 'disabletoken' to the allow-list, mirroring 'enabletoken'. Ticket: CHALO-1495
Contributor
hrishikeshjain
had a problem deploying
to
beta-alpha-release
September 29, 2026 13:41 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
|
|
danielpeng1
approved these changes
Sep 29, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendTokenEnablement's validation guard rejectedbuildParams.type === 'disabletoken', so disabling a Canton 1-step TransferPreapproval threwInvalid build of token enablement.immediately after a successful prebuild.Changes
prebuildTransactionTxRequestsalready handles'disabletoken'(added in f9ce83d, wiring thedisableTokenintent for Canton), but the companion allow-list insendTokenEnablement(used bysendTokenEnablements) still only accepted'enabletoken'/'enableMpt'. Added'disabletoken'to that allow-list, mirroring'enabletoken'.buildParams.type === 'disabletoken'passes validation and proceeds toinitiateTransaction, matching the existingenabletoken/enableMptcoverage.Test Plan
Automated:
modules/sdk-core/test/unit/bitgo/wallet/tokenApproval.ts)npx mocha test/unit/bitgo/wallet/**/*.ts— 221 passingnpx tsc --noEmit— cleannpx eslint— 0 errorsTicket (REQUIRED)
CHALO-1495
PR Checklist
Code Quality
Testing
Hygiene