Skip to content

Created a CMakeLists.txt file for the x11new port - #372

Merged
GitMensch merged 3 commits into
Bill-Gray:masterfrom
frostbane:x11
Sep 30, 2026
Merged

GitMensch merged 3 commits into
Bill-Gray:masterfrom
frostbane:x11

Conversation

@frostbane

Copy link
Copy Markdown
Contributor

This is a rough translation of the x11new Makefile.

@GitMensch

Copy link
Copy Markdown
Collaborator

Can you please add that to the main CMakeLists.txt file with an optional subdir build?
Ideally also adding the build cmake in the GH action, but that would be optional.

@frostbane

Copy link
Copy Markdown
Contributor Author

I added it to the main CMakeLists.txt but I didn't make use of the project_common.cmake.
I added PDC_X11_BUILD option to add the subdirectory optionally (defaults to OFF).

I never used GH actions, so maybe keep it tbd...?

@GitMensch

Copy link
Copy Markdown
Collaborator

There's no Appveyor run of x11 at all and GH actions only test vt11.
"Looks good in general" and as it seem to work for you as well I'm going to squash-merge as is.

@GitMensch
GitMensch merged commit d494b49 into Bill-Gray:master Sep 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants