Skip to content

Prevent export when no gap was found - #89

Merged
mszell merged 1 commit into
mainfrom
feature/no-zero-feature-export
Oct 2, 2026
Merged

mszell merged 1 commit into
mainfrom
feature/no-zero-feature-export

Conversation

@mszell

@mszell mszell commented Oct 2, 2026

Copy link
Copy Markdown
Member

Description

Prevent export when no gap was found

Related Issue

Fixes BikeNetKit/dataexport#79

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • 🧹 Code refactor (no functional changes)
  • ✅ Test update

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual testing

Test configuration:

  • OS:

Screenshots (if applicable)

Checklist

all applicable

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • New and existing tests pass locally

Additional Notes

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.89744% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fixbikenet/fixbikenet.py 35.89% 19 Missing and 6 partials ⚠️

📢 Thoughts on this report? Let us know!

@mszell
mszell merged commit 0259c0d into main Oct 2, 2026
12 of 13 checks passed
@mszell
mszell deleted the feature/no-zero-feature-export branch October 2, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zero-feature datasets

1 participant