Repository navigation
Conversation
json 3.0 removed the `quirks_mode` keyword, but ActiveSupport 8.0.5.1 and the EOL 6.0/6.1/7.0/7.1 lines still pass it to `JSON.generate`, so every worker error path raised `unknown keyword: quirks_mode` in CI. Rails 7.2.4 and 8.1 no longer pass the keyword and need no pin. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
smudge
requested review from
effron,
rzane and
samandmoore
and
a balanced review from Copilot
October 7, 2026 20:21
There was a problem hiding this comment.
🟢 Approval recommended
The constraints are consistent across appraisal definitions and generated Gemfiles, limited to test dependencies, and have no identified blocking issues.
0 open findings
What changed in this PR
Constrains test dependencies to avoid JSON encoding failures in affected Rails versions, without changing runtime dependencies.
Changes:
- Adds
json < 3to Rails 6.0, 6.1, 7.0, 7.1, and 8.0 appraisals. - Updates matching generated Gemfiles; leaves Rails 7.2 and 8.1 unchanged.
| File | Description |
|---|---|
| gemfiles/rails_8_0.gemfile | Adds Rails 8.0 JSON constraint. |
| gemfiles/rails_7_1.gemfile | Adds Rails 7.1 JSON constraint. |
| gemfiles/rails_7_0.gemfile | Adds Rails 7.0 JSON constraint. |
| gemfiles/rails_6_1.gemfile | Adds Rails 6.1 JSON constraint. |
| gemfiles/rails_6_0.gemfile | Adds Rails 6.0 JSON constraint. |
| Appraisals | Defines matching constraints for regeneration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
samandmoore
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json < 3in the Rails 6.0, 6.1, 7.0, 7.1 and 8.0 appraisals and regenerates their gemfiles.Why
gemfiles/*.lockis gitignored, so CI resolves fresh on every run. json 3.0 (3.0.2 at the time of writing) removed the long-deprecatedquirks_modekeyword, but ActiveSupport 8.0.5.1 and the EOL 6.0/6.1/7.0/7.1 lines still pass it toJSON.generate. Every job on those gemfiles now fails with 27 errors of the formunknown keyword: quirks_moderaised fromActiveSupport::JSON.encodeon the worker's error path.Rails 7.2.4 and 8.1 already dropped the keyword, so those appraisals pass unpinned and are left alone. The 8.0 pin can be removed once an 8.0.x patch with the fix ships; the older lines are EOL and will keep the pin.
How I verified the change
Risk / rollback
Low. Only affects which json version the test matrix installs. Revert the commit to undo.
🤖 Generated with Claude Code