Repository navigation
fix: block limiter usage if a transaction is open - #135
Merged
smudge merged 3 commits intoOct 7, 2026
Merged
Conversation
smudge
requested review from
AndrewSwerlick,
BetterBoyer,
effron and
samandmoore
October 7, 2026 19:54
json 3.0 removed the `quirks_mode` keyword, but ActiveSupport 8.0.5.1 and the EOL 6.0/6.1/7.0/7.1 lines still pass it to `JSON.generate`, so every worker error path raised `unknown keyword: quirks_mode` in CI. Rails 7.2.4 and 8.1 no longer pass the keyword and need no pin. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
smudge
force-pushed
the
smudge/rate-limiter-txn-protection
branch
from
October 7, 2026 20:16
d3e7921 to
6db2467
Compare
Merged
smudge
added a commit
that referenced
this pull request
Oct 7, 2026
Due to an absolutely clean merge, #135 didn't actually bump the gem's version number. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
with_limitis unlikely to trip this footgun, manual usage ofDelayed::Limit.within_limitwould strongly benefit from this guard.Going with a minor release since it could potentially break some existing code, but is also not a categorically breaking change for valid usages of these APIs.