Skip to content

gui: Let the home window choose its height - #78

Open
BenWestgate wants to merge 1 commit into
codex/gui-tails-field-testfrom
codex/gui-natural-home-height
Open

BenWestgate wants to merge 1 commit into
codex/gui-tails-field-testfrom
codex/gui-natural-home-height

Conversation

@BenWestgate

@BenWestgate BenWestgate commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Closes #75.

Remove the fixed 620px default height while keeping the existing 880px default width. GTK then uses the window content’s natural height for the initial home view; longer workflow pages remain inside the existing Gtk.ScrolledWindow and the window remains resizable.

This follows GTK4’s documented default-size behavior: an unset/default height uses the window’s natural size request rather than forcing a release-specific geometry. No workflow, navigation, wallet, or secret-handling behavior changes.

Current head 38373b3 is one commit / one file on current #77 head 72b5aae.

Manual qualification: confirm the initial home view is compact and longer pages still scroll normally at the supported Tails guest resolution before freezing the GUI candidate.

Disclosure: AI assistance was used for this authorized branch-to-branch presentation fix. Human review remains required before integration.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@BenWestgate BenWestgate added area: gui Graphical user interface behavior. gate: adversarial review Resolve, merge, or explicitly defer before the next full adversarial review. labels Sep 30, 2026 — with ChatGPT Codex Connector

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-generated release-gate review, posted at the maintainer's request.

Code ACK d510621.

The diff removes only the fixed default_height=620; the 880px default width, navigation, page content, and scrolling hierarchy are unchanged. GTK4 documents that an unset default dimension uses the window's natural size request, while the window remains resizable. Every workflow page is still hosted by the existing Gtk.ScrolledWindow, so longer pages remain usable at the smaller initial home height.

Manual qualification remains appropriate: verify the home opens compactly and a representative long page scrolls at the supported Tails guest resolution. No further automated Codex review request is warranted for this one-line behavior change.

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated release-gate review for rebased head 7b82ebc.

Code ACK. The PR is again exactly one commit / one file / one behavioral change on top of current #77: remove default_height=620 while retaining default_width=880. The prior review rationale is unchanged. Manual Tails confirmation of compact home height plus scrolling on a representative long page remains the only qualification item.

@BenWestgate
BenWestgate force-pushed the codex/gui-natural-home-height branch from 7b82ebc to 38373b3 Compare September 30, 2026 02:21

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated release-gate review for rebased head 38373b3.

Code ACK. The PR remains exactly one commit / one file / one behavioral change on top of current #77: remove default_height=620 while retaining default_width=880. Manual Tails confirmation of compact home height plus scrolling on a representative long page remains the only qualification item.

Copy link
Copy Markdown
Owner Author

Agent release-gate review at exact head 38373b3: this is a one-line behavioral layout change—leave width at 880 and omit the forced 620px height so GTK/libadwaita can use the home page's natural height. Long workflow pages still use the existing scrolled container. Exact-head run 36659468950 succeeded. No code-review blocker found; the initial home size and long-page scrolling still need the planned manual Tails guest-resolution check before the GUI candidate is frozen.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: gui Graphical user interface behavior. gate: adversarial review Resolve, merge, or explicitly defer before the next full adversarial review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant