gui: Let the home window choose its height - #78
BenWestgate wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated release-gate review, posted at the maintainer's request.
Code ACK d510621.
The diff removes only the fixed default_height=620; the 880px default width, navigation, page content, and scrolling hierarchy are unchanged. GTK4 documents that an unset default dimension uses the window's natural size request, while the window remains resizable. Every workflow page is still hosted by the existing Gtk.ScrolledWindow, so longer pages remain usable at the smaller initial home height.
Manual qualification remains appropriate: verify the home opens compactly and a representative long page scrolls at the supported Tails guest resolution. No further automated Codex review request is warranted for this one-line behavior change.
d510621 to
7b82ebc
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
Updated release-gate review for rebased head 7b82ebc.
Code ACK. The PR is again exactly one commit / one file / one behavioral change on top of current #77: remove default_height=620 while retaining default_width=880. The prior review rationale is unchanged. Manual Tails confirmation of compact home height plus scrolling on a representative long page remains the only qualification item.
7b82ebc to
38373b3
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
Updated release-gate review for rebased head 38373b3.
Code ACK. The PR remains exactly one commit / one file / one behavioral change on top of current #77: remove default_height=620 while retaining default_width=880. Manual Tails confirmation of compact home height plus scrolling on a representative long page remains the only qualification item.
|
Agent release-gate review at exact head |
Closes #75.
Remove the fixed 620px default height while keeping the existing 880px default width. GTK then uses the window content’s natural height for the initial home view; longer workflow pages remain inside the existing
Gtk.ScrolledWindowand the window remains resizable.This follows GTK4’s documented default-size behavior: an unset/default height uses the window’s natural size request rather than forcing a release-specific geometry. No workflow, navigation, wallet, or secret-handling behavior changes.
Current head
38373b3is one commit / one file on current #77 head72b5aae.Manual qualification: confirm the initial home view is compact and longer pages still scroll normally at the supported Tails guest resolution before freezing the GUI candidate.
Disclosure: AI assistance was used for this authorized branch-to-branch presentation fix. Human review remains required before integration.