Support Python 3.10 through 3.15 - #36
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb2d628a0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bb2d628 to
f49f06b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f49f06b8ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f49f06b to
f7049e3
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
looks good except for python-package.yml
f7049e3 to
3e25979
Compare
3e25979 to
6fc90d5
Compare
|
The Disclosure: AI-assisted verification of the current workflow and check results. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Stack refresh completed at |
|
Correction to my preceding refresh note: this branch is now refreshed to the current #7 head, but integration preflight against today’s |
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated review (Claude), posted at the maintainer's request.
Concept ACK. Code looks right; not ACKing 1b2e9c9 until it's rebased.
- The head is a merge of #7 (
1b2e9c9). CONTRIBUTING asks for no merge commits, so rebase 6fc90d5 onto #7's head, as the PR body already says. - I found no other 3.11+ APIs in
src.Profile(str, Enum)with__str__ = str.__str__also gives"ms"fromformat()/f-strings on 3.10/3.11. - 3.15 classifier/cap ahead of the 3.15.0 final is fine given
allow-prereleasesCI.
|
Release-gate recheck: the earlier “rebase before ACK” review condition is still real. Although the branch compares as 2 commits ahead / 0 behind |
1b2e9c9 to
860ffb0
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
71f77a9 to
012e562
Compare
Use Python 3.10-compatible enum, typing, and integer conversion forms while preserving existing behavior. Advertise and test Python 3.10 through 3.15, and make create tests robust to interpreter-level terminal probes. Security: no intended change to codex32 encoding, recovery, creation preflight, or wallet behavior. Validation: - python -m pytest -q tests/test_cli.py (223 passed) - python -m pytest -q (864 passed) - python -m mypy src/codex32 - python -m ruff check --target-version py310 . - python -m ruff format --check . - python -m build --no-isolation - python -m twine check built artifacts Refs #18.
012e562 to
5361df5
Compare
8338c72
into
3-remove-python-bip32-dependency
Closes #18.
This extends the supported interpreter range through Python 3.15 and makes 3.15 blocking CI coverage.
Profilestring behaviorcreateCLI test terminal double robust to interpreter-levelargparseTTY probes; productioncreatepreflight still requires only interactive stdin/stdout and still runs before Bitcoin Core initialization or entropyThe split CI matrix is deliberate: 3.12/3.13 exercise platform differences across Ubuntu, macOS, and Windows, while the Ubuntu compatibility job fills the remaining supported interpreters (3.10, 3.11, 3.14, and 3.15). Every supported Python therefore gets a full pytest run at least once. The 3.15 setup step permits prerelease resolution only for that matrix leg because GitHub's hosted Python toolcache does not yet expose a stable 3.15 build; the 3.15 job itself remains blocking.
Validation:
python -m pytest -q tests/test_cli.py— 223 passedpython -m pytest -q— 864 passedStacked on #7. The branch is one commit ahead of the current #7 head and zero behind.
Disclosure: AI tools were used while implementing and checking this user-requested branch-to-branch contribution.