ci: Remove bip32 and test Python 3.10-3.15 - #110
Open
BenWestgate wants to merge 1 commit into
Open
BenWestgate wants to merge 1 commit into
BenWestgate wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6012bcf728
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenWestgate
force-pushed
the
codex/master-ci-supported-python
branch
from
October 3, 2026 10:46
6012bcf to
2119aac
Compare
BenWestgate
changed the title
Legacy master advertises Python 3.13, but bip32 pins coincurve below 21 and fails during dependency installation. The only production use of bip32 is deriving an implicit identifier in from_seed. Require an explicit four-character identifier in that API instead, remove bip32 from package and test requirements, and test the advertised Python 3.10 through 3.15 range in both workflows. Setup-python v5 enables the 3.15 prerelease job.
BenWestgate
force-pushed
the
codex/master-ci-supported-python
branch
from
October 3, 2026 10:49
2119aac to
75f6972
Compare
BenWestgate
commented
Oct 4, 2026
BenWestgate
left a comment
BenWestgate
left a comment
Owner
Author
There was a problem hiding this comment.
AI-generated review (Codex), posted at the maintainer's request.
ACK 75f6972. The prior support mismatch is fixed: bip32 is removed and CI now covers Python 3.10–3.15.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
bip32from the legacy master package and test requirements.Codex32String.from_seednow requires a prefix with an explicit four-character identifier instead of calculating a default BIP32 fingerprint. Existing calls that already supply an identifier keep their behavior; calls without one now fail clearly.Restore Python 3.13 to both CI matrices and add 3.14 and prerelease 3.15.
setup-pythonv5 is needed for the 3.15 prerelease input.Why
Both master failures occur before tests or linting:
bip32pinscoincurve<21, whose build fails on Python 3.13. Removing 3.13 from CI alone would leave the advertised compatibility untested. This patch removes that dependency and tests Python 3.10–3.15. Callers creating wallet backups must supply an identifier from an independently verified wallet record; this reference API does not calculate or verify a fingerprint.Refs #7 for the separate v1 dependency removal.
Validation
git diff --checkpasses.AI-assisted implementation. Human review and a verified human signature are required before merge.