share: Show the master fingerprint after the threshold - #100
Open
BenWestgate wants to merge 2 commits into
Open
BenWestgate wants to merge 2 commits into
BenWestgate wants to merge 2 commits into
Conversation
BenWestgate
marked this pull request as ready for review
October 1, 2026 13:54
BenWestgate
force-pushed
the
30-recorded-fingerprint-gate
branch
3 times, most recently
from
October 2, 2026 08:57
054e8d9 to
115f2c2
Compare
`ms32 secret` shows the master fingerprint with the recovered secret, but `ms32 share` never did, so the operator couldn't compare it with the wallet record before writing a new card. Print it above the derived share on a terminal, whether every input is a share or one of them is the secret. `--plain` and redirected output stay unchanged. Closes #86 Claude-Session: https://claude.ai/code/session_015CuLXqAvAovfoVcUmmogwa
BenWestgate
force-pushed
the
claude/new-issue-fixes-fvhbl3-86
branch
from
October 2, 2026 17:18
eb37865 to
8aaf0fa
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Ben authorized raising the budget so #91 fits. The stack tip with the open fix PRs was at 5,197 of 5,200, and #91 adds 26 lines. Update the enforcing test and both places that document the number. Claude-Session: https://claude.ai/code/session_015CuLXqAvAovfoVcUmmogwa
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
Before:
ms32 secretprinted the master fingerprint, butms32 sharenever did, so the operator couldn't check it against the wallet record before writing a new card.After: on a terminal,
ms32 shareprintsMaster fingerprint: XXXXXXXXabove the derived share, whether every input is a share or one of them is the secretS.--plainand redirected output are unchanged.How: four lines in
_share_command. The fingerprint comes from the entered secret, or from recovering the secret from the entered shares. #57's typed-fingerprint gate forwalletandcreate --existingis untouched.Budget: 5193 of < 5200. 922 tests pass; ruff and mypy are clean.
Closes #86
🤖 Generated with Claude Code
https://claude.ai/code/session_015CuLXqAvAovfoVcUmmogwa
Generated by Claude Code