Skip to content

share: Show the master fingerprint once the threshold is entered #86

Description

@BenWestgate

ms32 secret shows the master fingerprint along with the recovered secret. ms32 share never shows it. It doesn't appear while confirming a correction to an input, with the derived share, or when the secret itself is one of the inputs.

Show it once the threshold of input strings has been accepted, whether every input is a share or one of them is the secret. The operator can then compare it with the wallet record before writing a new card for the set.

This doesn't change #57's rule that ms32 wallet and ms32 create --existing keep the recovered fingerprint hidden until the operator types the recorded one.

In the code, _share_command in cli.py calls _emit(derived, plain) without a fingerprint. _confirm_correction previews the fingerprint only when basis is false, and share never passes false.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: cliCommand-line interface behavior.enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions