You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to the review question on #12 and the v1 API-boundary pass.
core_descriptors(...) is a legacy public adapter from before Bitcoin Core became the sole EC/HD-key integration. It is still exported in codex32.__all__ on current reviewability-v1, while production EC/public-derivation work lives behind _bitcoin_core.py.
#7 has since moved wallet initialization to Bitcoin Core's Core-native HD-key/descriptor setup and intentionally limits that v1 path to account 0. #68 separately tracks nonzero accounts when Bitcoin Core exposes the needed native selector. Therefore this issue must not preserve the old arbitrary ms32 wallet --account implementation by replaying Python private-descriptor construction.
Acceptance:
remove core_descriptors from package-level codex32.__all__ and from supported public documentation;
remove the unused public-deriver abstraction/branch from wallet.py;
keep any descriptor/checksum helpers still needed by the current Core adapter/tests/tools private and explicitly underscored;
rerun the focused public-API/Core tests and the real-Core fixture where relevant after the final refresh.
#64 is the reviewed focused implementation, but its historical patch predates #7 and contains an obsolete _bitcoin_core.py hunk. Refresh #64 after the runtime stack settles and replay only the API-surface cleanup that still matches current code.
This is an API-surface cleanup, not a release-budget refactor or a reason to undo the Core-native initialization boundary.
Follow-up to the review question on #12 and the v1 API-boundary pass.
core_descriptors(...)is a legacy public adapter from before Bitcoin Core became the sole EC/HD-key integration. It is still exported incodex32.__all__on currentreviewability-v1, while production EC/public-derivation work lives behind_bitcoin_core.py.#7 has since moved wallet initialization to Bitcoin Core's Core-native HD-key/descriptor setup and intentionally limits that v1 path to account 0. #68 separately tracks nonzero accounts when Bitcoin Core exposes the needed native selector. Therefore this issue must not preserve the old arbitrary
ms32 wallet --accountimplementation by replaying Python private-descriptor construction.Acceptance:
core_descriptorsfrom package-levelcodex32.__all__and from supported public documentation;wallet.py;master_xprvunchanged unless separately reviewed;#64 is the reviewed focused implementation, but its historical patch predates #7 and contains an obsolete
_bitcoin_core.pyhunk. Refresh #64 after the runtime stack settles and replay only the API-surface cleanup that still matches current code.This is an API-surface cleanup, not a release-budget refactor or a reason to undo the Core-native initialization boundary.