Skip to content

reviewability: restore the <5000 installed-package budget on the integrated v1 tree #61

Description

@BenWestgate

A disposable integration from reviewability-v1 26f933e exposed a release-gate failure that individual PR CI cannot see.

Current logical review-line counts (nonblank, non-comment src/codex32/**/*.py, matching test_production_size_budgets_are_enforced):

docs/developer/api.md requires the installed v1 package to remain below 5,000 lines and says changing that budget requires explicit review and authorization. Do not raise the threshold as part of this issue.

Acceptance:

  • reduce the integrated production tree to <5000 without weakening correct: Interpret mixed-case damage #42 mixed-case correction or wallet: Require the recorded fingerprint before import #57 verify-before-mutate / wallet-record behavior;
  • keep the cleanup focused on real review-surface reduction, not formatting compression or moving live runtime code outside the counted package;
  • rerun the exact production-size test on the combined tree plus normal/optimized tests covering touched paths;
  • fold the final result into the one-time post-prerequisite cleanup refresh before the frozen adversarial-review candidate is declared.

The disposable integration worktree only produced local synthetic commits; no project branch was changed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: cliCommand-line interface behavior.area: correctionCorrection engine and correction UX.area: packaging/releasePackaging, artifacts, compatibility, and release qualification.area: wallet/coreWallet integration and Bitcoin Core boundaries.bugSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions