Repository navigation
Fix install executable flags on Unix based systems - #1609
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the CMake installation script where executables were not being installed with the correct permissions on Unix-based systems. The issue was that install(FILES ...) was being used instead of install(PROGRAMS ...) in the install_bin function, which meant that installed executables like ShaderTool lacked execute permissions after installation.
Changes:
- Changed
install(FILES ...)toinstall(PROGRAMS ...)in theinstall_binfunction to ensure executables are installed with execute permissions on Unix systems
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bghgary
enabled auto-merge (squash)
February 19, 2026 16:49
bkaradzic-microsoft
pushed a commit
to bkaradzic-microsoft/BabylonNative
that referenced
this pull request
Jul 10, 2026
…at, GPU-particle, remote-asset tests) Replace stale/generic exclude reasons with the verbatim runtime error each test actually hits on Babylon Native, re-verified on a fresh master build: - Texture-format tests (BabylonJS#1609 family): RuntimeError: Unsupported texture format or type ... instead of a pixel-diff label. - GPU-particle tests: the verbatim TypeError/ReferenceError thrown before rendering (ARRAY_BUFFER, 'Image'), and reuse of the existing 'Cubemap load not implemented on Babylon Native' convention. - Remote-asset / misc tests: several were mislabeled as generic pixel-diff or crash; use the actual thrown error (Unable to load ... Unknown error opening URL for curl-reachable URLs, createObjectURL missing, OBJ 'Out of stack space', cubemap load gap), or the measured pixel-diff. Reason-string wording only; no test is enabled or disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.