Repository navigation
Fix install cmake to include ShaderTool - #1607
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CMake installation logic in Install/Install.cmake to improve clarity and adds installation support for the ShaderTool binary. The refactoring replaces generic function names with more specific ones that clearly indicate their purpose: install_lib for libraries, install_bin for executables, and install_include for header files.
Changes:
- Renamed
install_targetstoinstall_libandinstall_include_for_targetstoinstall_includefor better semantic clarity - Introduced a new
install_binfunction for installing executable binaries - Added installation support for the ShaderTool executable, which was previously not being installed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bghgary
enabled auto-merge (squash)
February 18, 2026 19:54
bkaradzic-microsoft
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the installation logic in the
Install.cmakefile to improve clarity and modularity. The main change is replacing the genericinstall_targetsandinstall_include_for_targetsfunctions with more specific functions:install_lib,install_bin, andinstall_include. This makes it clearer what kind of installation each target requires and allows for more granular control, such as installing binaries separately.Key changes include:
Refactoring and Function Renaming:
install_targetsfunction withinstall_lib, which is now used for installing library targets throughout the file. (Install/Install.cmake) [1] [2] [3]install_include_for_targetsfunction withinstall_include, standardizing how include directories are installed for targets. (Install/Install.cmake) [1] [2] [3]install_binfunction to handle binary installations, used for theShaderTooltarget. (Install/Install.cmake) [1] [2]Consistent Application Across Targets:
install_lib,install_include, andinstall_binfunctions for core libraries, plugins, polyfills, and other modules. (Install/Install.cmake) [1] [2]These changes make the CMake installation process more explicit and maintainable, reducing ambiguity and potential errors in future updates.