Repository navigation
Replace ifstream/ofstream with istream/ostream in ShaderCache - #1606
Merged
Merged
Conversation
bghgary
enabled auto-merge (squash)
February 18, 2026 16:40
bghgary
requested review from
CedricGuillemet
and removed request for
Copilot
February 18, 2026 16:40
CedricGuillemet
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the shader cache serialization and deserialization logic to use more generic stream types, improving flexibility and code reuse. The main change is replacing the use of file stream types (
std::ifstream,std::ofstream) with their base stream types (std::istream,std::ostream) throughout the shader cache API and implementation.API and Implementation Stream Type Generalization
SaveandLoadfunctions in theBabylon::Plugins::ShaderCachenamespace andShaderCacheImplclass to usestd::ostreamandstd::istreaminstead ofstd::ofstreamandstd::ifstream, allowing for more flexible stream handling. [1] [2] [3] [4] [5] [6]SaveStringandLoadStringto acceptstd::ostreamandstd::istreamparameters instead of file streams, supporting the generalized stream usage.