Repository navigation
Document the units for size related parameters in the public contract - #1586
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds documentation to clarify that size-related parameters use device-independent pixels (dp/dip) as their unit of measurement across multiple components of the graphics and input system.
- Documents that mouse and touch coordinates in NativeInput use device-independent pixels relative to the back buffer
- Adds inline comments to DeviceImpl.h to clarify Width/Height are in device-independent pixels
- Enhances Device.h configuration struct documentation to explain Width/Height units and their relationship to rendering dimensions via hardware scaling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Plugins/NativeInput/Include/Babylon/Plugins/NativeInput.h | Adds comment documenting that mouse coordinate parameters use device-independent pixels |
| Core/Graphics/Source/DeviceImpl.h | Adds inline comments to Resolution Width/Height fields indicating device-independent pixel units |
| Core/Graphics/Include/Shared/Babylon/Graphics/Device.h | Enhances documentation for Width/Height configuration parameters with unit information and hardware scaling remarks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryantrem
approved these changes
Jan 9, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bghgary
commented
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bghgary
marked this pull request as ready for review
January 9, 2026 22:28
bghgary
enabled auto-merge (squash)
January 9, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.