Repository navigation
[Feat] 밴드 생성 요청에 대한 검수 단계 추가 - #412
Merged
Merged
Conversation
LeeJuYoung12
approved these changes
Aug 23, 2026
Comment on lines
+19
to
+25
| @Table( | ||
| name = "Band", | ||
| uniqueConstraints = @UniqueConstraint( | ||
| name = "uk_band_name_status", | ||
| columnNames = {"name", "status"} | ||
| ) | ||
| ) |
Contributor
There was a problem hiding this comment.
밴드 네임의 유니크를 빼고 해당부분으로 유니크 제약거는데 status가 pending, accepted 2개뿐이기에 필요할까라는 생각이 드는데 어떤 목적이 있을까요?
Contributor
Author
There was a problem hiding this comment.
기존에 더미로 존재하는 밴드는 이미 ACCEPTED로 지정하게 되어 있는데, 그 밴드들이 새로 가입 신청을 하게 되면 새로 band 테이블에 인스턴스로 추가하게 되어있습니다. 그렇다면 유니크 제약 조건에 걸리게 되어 무조건 덮어씌워야 하는데 그 부분이 걸려서 상태, 이름을 섞어서 유니크 제약조건을 걸었습니다.
newjini9
reviewed
Aug 24, 2026
newjini9
approved these changes
Aug 25, 2026
[Feat] 탐색 검색에 isDummy 파라미터 추가 및 더미 밴드 필터링
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔎 관련 이슈
📋 작업 내용
💡 알림
DISCORD_BOT_TOKEN,DISCORD_VERIFY_CHANNEL_ID를 환경변수에 추가 필요✅ 체크리스트
엔드포인트체크Http Method체크📸 스크린샷