Repository navigation
fix: use process-only preview flags for agents - #10683
Merged
Merged
Conversation
Hui Miao (huimiu)
requested review from
JeffreyCA,
JerryYang (JerryYangKai),
FanH (Siglud),
Yimin-Jin,
Eric Chen (eriolchan),
Glenn Harper (glharper),
Zhijie Huang (hund030),
Wei Meng (m5i-work),
John Miller (therealjohn),
Travis Angevine (trangevi) and
JianW (v1212)
as code owners
October 23, 2026 02:25
|
Azure Pipelines: Successfully started running 2 pipeline(s). 24 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Direct os.Getenv access can consume host-injected azd environment values, so the required process-only contract is not currently enforced.
1 open issue
What changed in this PR
This pull request updates agents preview feature flags to use canonical AZD_ALPHA_ENABLE_AGENTS_* names, exposes them through root help, and removes legacy configuration and dependency handling. A critical issue remains: direct os.Getenv access can observe host-injected azd environment values, violating the documented process-only contract.
Changes:
- Simplifies feature evaluation to parse canonical process environment variables.
- Updates the registry, tests, help output, snapshot, and Tier 0 discovery scenario.
- Removes obsolete indirect dependencies and documents the revised feature-flag contract.
| File | Description |
|---|---|
cli/azd/extensions/azure.ai.agents/tests/cli-interactive-tester-scenarios/tier0/0.02-help-root.yaml |
Adds offline assertions for preview switch discovery and guidance. |
cli/azd/extensions/azure.ai.agents/internal/featureflags/registry.go |
Defines canonical AZD_ALPHA_ENABLE_* environment keys. |
cli/azd/extensions/azure.ai.agents/internal/featureflags/registry_test.go |
Verifies canonical feature IDs, keys, and registry behavior. |
cli/azd/extensions/azure.ai.agents/internal/featureflags/featureflags.go |
Implements declaration validation and environment-based feature evaluation. |
cli/azd/extensions/azure.ai.agents/internal/featureflags/featureflags_test.go |
Covers parsing, defaults, ignored sources, isolation, and mutation safety. |
cli/azd/extensions/azure.ai.agents/internal/cmd/testdata/TestAgentHelp-root.snap |
Updates the root help snapshot with preview switch guidance. |
cli/azd/extensions/azure.ai.agents/internal/cmd/root.go |
Installs registry-generated help content. |
cli/azd/extensions/azure.ai.agents/internal/cmd/help.go |
Renders registry-derived preview switch documentation. |
cli/azd/extensions/azure.ai.agents/internal/cmd/help_test.go |
Tests help content, formatting, snapshots, and switch independence. |
cli/azd/extensions/azure.ai.agents/go.sum |
Removes checksums for obsolete dependencies. |
cli/azd/extensions/azure.ai.agents/go.mod |
Removes obsolete indirect module requirements. |
cli/azd/extensions/azure.ai.agents/docs/specs/preview-feature-flags.md |
Documents the process-only API, canonical names, and deferred adoption boundary. |
Review effort: Lite
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
Hui Miao (huimiu)
added this pull request to stack #10687
October 23, 2026 04:58
Contributor
azure.ai.agents PR buildNote This is an unsigned development build. Install it only if you trust this PR. Install the extension: azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10683/azure-ai-agents.zip"
|
Zhijie Huang (hund030)
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep preview-flag evaluation inside the agents extension until azd core provides shared support. Use
AZD_ALPHA_ENABLE_AGENTS_*names now so the later migration can keep the same switches and feature IDs.This PR updates evaluation and help only. Command and runtime gates remain in #10640.
Changes
AZD_FOUNDRY_EXT_ENABLE_*with switches for managed harness, voice, and long-running invocation. Each defaults to off and enables only for true values accepted bystrconv.ParseBool.azd ai agent --helpand update the docs, tests, root help snapshot, and Tier 0 help scenario.Testing
Feature-flag and help tests, the full agents module build, and scoped vet/lint checks passed. The updated Tier 0 help scenario was not run.
Closes #10684