Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 65 additions & 2 deletions .github/scripts/check-plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,18 @@
wants a string. Claude Code accepted all of it, which is why the break reached a
release unnoticed.

So this script checks the two halves of what a host needs:
So this script checks what a host needs:

* every command and skill the manifests promise parses, and parses to the types a
loader expects;
* every manifest promises the same thing, because the plugin is published through
five of them and a version bump that misses one ships a lie.
five of them and a version bump that misses one ships a lie;
* each Gemini ``.toml`` adapter describes its command the same way the canonical
Markdown does. The same text is written twice, once per host, so it drifts: the
feedback adapter went on advertising a ZIP long after the skill stopped
producing one;
* no development test or fixture sits inside a skill directory, since whatever is
in there is downloaded by everyone who installs the plugin.

The guard against parser differences is quoting, not parseability. A quoted
scalar is a string under every YAML implementation regardless of what it
Expand Down Expand Up @@ -43,6 +49,11 @@
except ImportError: # optional, see module docstring
yaml = None

try:
import tomllib # Python 3.11+; the adapter check is skipped without it
except ImportError:
tomllib = None

REPO = Path(__file__).resolve().parents[2]

# Every manifest that publishes this plugin. Each entry is the file and the
Expand Down Expand Up @@ -164,6 +175,55 @@ def check_markdown(rel: str, kind: str) -> None:
fail(rel, f"{key} parses as {got}, not str: {data[key]!r}")


def check_adapters(commands: list[str]) -> None:
"""Each Gemini .toml must describe its command exactly as the Markdown does.

The description is authored twice, once per host, with nothing tying the
copies together. That is how the feedback adapter kept advertising a ZIP
after the skill had moved to returning an anonymized summary.
"""
if tomllib is None: # Python < 3.11, see module docstring
return
for entry in commands:
rel = entry.lstrip("./")
name = Path(rel).stem
adapter = REPO / "commands" / "aigateway" / f"{name}.toml"
canonical = REPO / rel
if not adapter.is_file() or not canonical.is_file():
continue
try:
want = tomllib.loads(adapter.read_text(encoding="utf-8")).get("description")
except tomllib.TOMLDecodeError as exc:
fail(f"commands/aigateway/{name}.toml", f"invalid TOML: {exc}")
continue

lines = split_frontmatter(canonical.read_text(encoding="utf-8")) or []
got = None
for line in lines:
match = re.match(r"^description:\s*(.*)$", line)
if match:
got = match.group(1).strip().strip("\"'")
if got is not None and want != got:
fail(
f"commands/aigateway/{name}.toml",
"description does not match "
f"{rel}\n toml: {want}\n md: {got}",
)


def check_no_bundled_tests() -> None:
"""Skill directories ship to users; development files do not belong in them."""
stray = sorted(
str(path.relative_to(REPO))
for pattern in ("*/tests/*", "*/evals/*", "*/test_*.py")
for path in (REPO / "skills").glob(pattern)
# Local build artifacts are gitignored; do not fail a developer's run.
if "__pycache__" not in path.parts
)
for path in stray:
fail(path, "development file inside a shipped skill; move it under tests/")


def main() -> int:
manifests: dict[str, dict] = {}
for rel in MANIFESTS:
Expand Down Expand Up @@ -210,6 +270,9 @@ def main() -> int:
for entry in base.get("skills", []):
check_markdown(f"{entry.strip('./')}/SKILL.md", "skill")

check_adapters(base.get("commands", []))
check_no_bundled_tests()

strict = "with" if yaml else "without"
checked = len(base.get("commands", [])) + len(base.get("skills", []))
if failures:
Expand Down
18 changes: 8 additions & 10 deletions commands/aigateway/feedback.toml
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
description = "Package a selected session into a local feedback ZIP, with mandatory anonymization and review for GitHub issues."
description = "Collect session feedback on friction points and completed work for Azure AI Gateway insights. Process and anonymize a session summary, returning a clean file ready for sharing."

prompt = """
Follow `skills/feedback-ai-gateway/SKILL.md` and its bundled local Python helper.
Obtain consent for one selected session export and any optional diagnostic files.
Use the host's supported export mechanism for Copilot, Claude, Gemini, Cursor,
or another agent; report missing telemetry and never read unrelated sessions.
Return a local ZIP without uploading. For private handoff, let the user choose
whether to anonymize. For GitHub issue sharing, always semantically anonymize all
selected content, run helper scrubbing, review the final ZIP and issue title/body,
and obtain explicit publication approval. Never post raw/private bundles.
The user can attach the reviewed ZIP through GitHub's browser upload;
do not invent a ZIP attachment option for gh issue create.
Resolve the arguments into the selected summary file and output directory.
Obtain consent before reading the summary file. Verify that the file is a
summary (friction, tasks, outcomes) and not a full transcript. Never accept
full session histories or conversation exports.
Return an anonymized summary file to the user; never upload automatically.
Do not suggest or facilitate sharing to GitHub, email, or any other service.
All sharing decisions belong to the user.

Feedback request: {{args}}
"""
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@


SPEC = importlib.util.spec_from_file_location(
"feedback", Path(__file__).parents[1] / "scripts" / "feedback.py"
"feedback",
Path(__file__).parents[2] / "skills" / "feedback-ai-gateway" / "scripts" / "feedback.py",
)
feedback = importlib.util.module_from_spec(SPEC)
SPEC.loader.exec_module(feedback)
Expand Down
Loading