Repository navigation
Fetch segments inside a unit of work - #202
Open
stefanmirkovic wants to merge 1 commit into
Open
stefanmirkovic wants to merge 1 commit into
stefanmirkovic wants to merge 1 commit into
Conversation
Axon Framework 5.5 requires a non-null ProcessingContext for every TokenStore operation, and JpaTokenStore rejects work outside a transaction. createSegmentOverview passed null to fetchSegments, so the client no longer compiled against 5.5.0-SNAPSHOT and the nightly compatibility build failed. The call now runs in a unit of work from the configured UnitOfWorkFactory, which is transactional in a Spring application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly compatibility build against Axon Framework 5.5.0-SNAPSHOT fails to compile. AF commit edbc5a524d ("Require a processing context for token store operations") made the ProcessingContext of every TokenStore operation non-null, and JpaTokenStore now rejects work outside a transaction.
ProcessorReportCreator.createSegmentOverviewpassednulltofetchSegments.The call now runs in a unit of work from the configured
UnitOfWorkFactory, the same wayRSocketModelInspectionResponderloads entities. In a Spring application that factory is transactional, so a JPA token store works too.Built locally against 5.5.0-SNAPSHOT and against the version in the pom (5.3.2): 193 tests green in both. The Toxiproxy integration test was skipped locally because its container did not start on my machine.