Repository navigation
Delegate overrideAppendCondition in the event store transaction wrapper and release 5.4.2 - #200
Merged
Merged
Conversation
The interface default throws UnsupportedOperationException, so workflows, which override the append condition on every step, failed as soon as the Platform client wrapped the event store. Taken from #196 to release it without the workflow telemetry feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AxoniqPlatformEventStorewraps theEventStoreTransactionbut did not forwardoverrideAppendCondition(). The interface default throwsUnsupportedOperationException, so any application that overrides the append condition fails as soon as the Platform client is on the classpath. Workflows do this on every step, which blocks workflow execution entirely (reported by a customer on AF 5.4.1).The fix is taken from #196 so it can ship without waiting for the workflow telemetry feature.
Changes
AxoniqPlatformEventStoreTransactiondelegatesoverrideAppendCondition()to the wrapped transaction.AxoniqPlatformEventStoreTestchecks that the modifier reaches the underlying transaction.5.4.2, so merging this releases to Maven Central.overrideAppendCondition()already exists in AF 5.3.2, so no framework bump is needed.Other wrappers
I checked every delegating wrapper in the client against the AF 5.4.1 interfaces. No other default method throws. A few are not forwarded, but they lose information rather than fail:
AxoniqPlatformQueryBusdoes not forward the*AndCountmethods (emitUpdateAndCountand the twocompleteSubscriptions*AndCount). Updates still reach subscribers, but the count comes back asOptionalInt.empty().priority(),canHandleType()andattribute(), unlike AF'sWrappedMessageHandlingMember.I will look at those in a separate PR.
After merge,
mainneeds to go back to5.4.3-SNAPSHOT.