Repository navigation
Recognize accordion items whose own element is the disclosure control - #3050
Merged
Merged
Conversation
chubes4
force-pushed
the
fix/issue-3049-blocks-engine
branch
from
October 18, 2026 21:09
329aa59 to
cf17528
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captured accordion panels used to be saved with their closed-state class list, including Tailwind `hidden`. core/accordion opens a panel only by removing the `hidden` attribute, so the `hidden` class kept every panel invisible. AccordionPattern now works out the panel's styling from the recorded open-state class list and drops the classes that only the closed state has. This applies to item-level controls and title buttons alike. The toggle icon keeps its resting (closed) class list. The fix is committed locally as c767b7a5 but not pushed, because the branch has no upstream set.
What changed
How to test
cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test:canonical; expect passes as recorded by Cook's deterministic gate.Compatibility
Only affects accordion panels that carry the capture's open-class attribute. Panels without it are lowered exactly as before. The toggle icon and heading presentation are unchanged.
Evidence
cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test:canonical: status=succeeded; candidate commit47d4149c918e7c76d02f35a7093ef2445744a976, treeaa3674031104ebfc879b40a89d3669c3d4b642dc, fingerprint918194ccc81fc790a8d5d4a98acb817a8b5317a68c4e495cc35ce8b75fdd9dca; durable gategate-1AI assistance