Repository navigation
Scope interaction-state refusals to elements the state rule can match (#3042) - #3047
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attribute-only state rules such as `[type="checkbox"]:indeterminate:hover` no longer stop non-matching elements (navy sections) from binding to palette presets. Rules that can match, like `section:hover`, `a:hover` on links and `:hover`, still refuse. Fixes the candidate, which ignored class tokens (so `.text-rose:hover` blocked every element and broke the tailwind binding tests) and read attributes from descendants.
What changed
How to test
cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test:canonical; expect passes as recorded by Cook's deterministic gate.Compatibility
No public API change. Binding results change only where an attribute state rule was over-blocking. Everything else matches the code before the candidate. composer test:canonical passes; phpstan and phpcs are clean on PresetBinding.php.
Evidence
cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test:canonical: status=succeeded; candidate commitee8d0b914a490ef1bbf5dbd94a622ce34554c0a3, treed4203b9a0bbe11a2ee43abb3b6226dc7cdc99ade, fingerprint231721507153e3998479a26215e42b3e622a610c8a4785e77c08a661cbdfe918; durable gategate-1AI assistance