Repository navigation
Ignore fragment-only links when naming the front page - #3045
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated front-page navigation label selection so same-page fragment links do not supply the page name. When there is no eligible hash-less link, existing title fallbacks can apply.
What changed
How to test
cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test; expect passes as recorded by Cook's deterministic gate.Compatibility
Fragment-only links no longer name the front page; hash-less home links continue to be used. Existing title fallbacks handle cases without an eligible link.
Evidence
cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test: status=succeeded; candidate commiteeb471474374d36de1840b096e5c2effb0cf3762, treee5b0ccf98a1c7a7753e6c715f3de8b23c3fc90b2, fingerprint61c1cf0ba62f101f147419f1beab0c756a01c0a514156dc8ce81d786c8b80ace; durable gategate-1AI assistance