Skip to content

Ignore fragment-only links when naming the front page - #3045

Merged
chubes4 merged 2 commits into
trunkfrom
fix/issue-3041-blocks-engine
Oct 18, 2026
Merged

chubes4 merged 2 commits into
trunkfrom
fix/issue-3041-blocks-engine

Conversation

@chubes4

@chubes4 chubes4 commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Updated front-page navigation label selection so same-page fragment links do not supply the page name. When there is no eligible hash-less link, existing title fallbacks can apply.

What changed

  • Changed `ArtifactCompiler::entryNavigationLabel()` to return only a hash-less navigation label instead of falling back to any link targeting `/`.
  • Ran `php php-transformer/tests/contract/run.php`; it passed.

How to test

  1. Run cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test; expect passes as recorded by Cook's deterministic gate.

Compatibility

Fragment-only links no longer name the front page; hash-less home links continue to be used. Existing title fallbacks handle cases without an eligible link.

Evidence

  • Verified command cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test: status=succeeded; candidate commit eeb471474374d36de1840b096e5c2effb0cf3762, tree e5b0ccf98a1c7a7753e6c715f3de8b23c3fc90b2, fingerprint 61c1cf0ba62f101f147419f1beab0c756a01c0a514156dc8ce81d786c8b80ace; durable gate gate-1
  • Base unchanged since verification: trunk remains at 354dfdf.
  • CI expected: Homeboy CI after push
  • Candidate adoption provenance: the candidate was promoted from the recorded Cook task execution.
  • Cook deterministic verification: 1 gate(s) completed green.
  • Durable run execution: Succeeded
  • Reviewer-resolvable evidence from source_refs[0]: Front page is named after a same-page fragment nav link ("Area of Focus expand_more") #3041
  • Task objective: Front page is named after a same-page fragment nav link ("Area of Focus expand_more") #3041
  • Verified candidate scope: 1 changed file(s): php-transformer/src/ArtifactCompiler/ArtifactCompiler.php.
  • Verified finalization base: trunk at 354dfdf
  • deterministic gate passed: sh -c cd php-transformer && composer install --no-interaction --prefer-dist --no-progress && composer test (Passed)

AI assistance

@chubes4 chubes4 closed this Oct 18, 2026
@chubes4 chubes4 reopened this Oct 18, 2026
@chubes4
chubes4 merged commit 58de19e into trunk Oct 18, 2026
15 checks passed
@chubes4
chubes4 deleted the fix/issue-3041-blocks-engine branch October 18, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant