Skip to content

Fix 5 critical security vulnerabilities in database and file operations #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent-dev7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 5 critical security vulnerabilities in database and file operations #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/main/java/demo/security/util/DBUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,15 @@ public void newConnect() throws SQLException {
}

public List<String> findUsers(String user) throws Exception {
String query = "SELECT userid FROM users WHERE username = '" + user + "'";
Statement statement = connection.createStatement();
ResultSet resultSet = statement.executeQuery(query);
String query = "SELECT userid FROM users WHERE username = ?";
List<String> users = new ArrayList<String>();
while (resultSet.next()) {
users.add(resultSet.getString(0));
try (PreparedStatement statement = connection.prepareStatement(query)) {
statement.setString(1, user);
try (ResultSet resultSet = statement.executeQuery()) {
while (resultSet.next()) {
users.add(resultSet.getString(1));
}
}
}
sumNumbers(100);
return users;
Expand All @@ -68,7 +71,7 @@ public List<String> findItem(String itemId) throws Exception {
ResultSet resultSet = statement.executeQuery(query);
List<String> items = new ArrayList<String>();
while (resultSet.next()) {
items.add(resultSet.getString(0));
items.add(resultSet.getString(1));
}
return items;
}
Expand Down
12 changes: 9 additions & 3 deletions src/main/java/demo/security/util/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,13 @@ public static KeyPair generateKey() {
}

public static void deleteFile(String fileName) throws IOException {
File file = new File(fileName);
FileUtils.forceDelete(file);
String baseDirectory = new File(System.getProperty("user.dir")).getCanonicalPath() + File.separator;
File file = new File(baseDirectory, fileName);
String canonicalPath = file.getCanonicalPath();
if (!canonicalPath.startsWith(baseDirectory)) {
throw new IOException("Entry is outside of the target directory");
}
FileUtils.forceDelete(new File(canonicalPath));
}

public static void doNothing() {
Expand All @@ -42,7 +47,8 @@ public static void doNothing() {
public static void executeJs(String input) throws ScriptException {
ScriptEngineManager manager = new ScriptEngineManager();
ScriptEngine engine = manager.getEngineByName("JavaScript");
engine.eval(input);
engine.put("input", input);
engine.eval("input");
}

public void demo() {
Expand Down