Skip to content

Fix 5 SonarQube code quality violations across utility and servlet classes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent-dev7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 5 SonarQube code quality violations across utility and servlet classes #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/demo/security/servlet/HomeServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ protected void doGet(HttpServletRequest request,
out.close();
}

@Override
protected void doPost(HttpServletRequest request,
HttpServletResponse response) throws ServletException, IOException {
// TODO Auto-generated method stub
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/demo/security/servlet/Insecure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import java.security.NoSuchAlgorithmException;
import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;

import javax.servlet.http.Cookie;
Expand All @@ -32,20 +33,20 @@ public void badFunction(HttpServletRequest request) throws IOException {
Files.exists(Paths.get("/tmp/", obj));
}

public String taintedSQL(HttpServletRequest request, Connection connection) throws Exception {
public String taintedSQL(HttpServletRequest request, Connection connection) throws SQLException {
String user = request.getParameter("user");
String query = "SELECT userid FROM users WHERE username = '" + user + "'";
Statement statement = connection.createStatement();
ResultSet resultSet = statement.executeQuery(query);
return resultSet.getString(0);
}

public String hotspotSQL(Connection connection, String user) throws Exception {
Statement statement = null;
statement = connection.createStatement();
ResultSet rs = statement.executeQuery("select userid from users WHERE username=" + user);
return rs.getString(0);
}
public String hotspotSQL(Connection connection, String user) throws SQLException {
Statement statement = null;
statement = connection.createStatement();
ResultSet rs = statement.executeQuery("select userid from users WHERE username=" + user);
return rs.getString(0);
}

// --------------------------------------------------------------------------
// Custom sources, sanitizer and sinks example
Expand Down
14 changes: 7 additions & 7 deletions src/main/java/demo/security/util/DBUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
import java.sql.*;
import java.util.ArrayList;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;

public class DBUtils {
private static final Logger LOGGER = Logger.getLogger(DBUtils.class.getName());

Object value;

Connection connection;
Expand Down Expand Up @@ -79,12 +83,6 @@ public void sumNumbers(int max) {
count = 0;
for (int i = 2; i <= number / 2; i++) {
if (number % i == 0) {
for (int m = 2; i <= number / 2; i++) {
if (number % m == 0) {
count++;
break;
}
}
count++;
break;
}
Expand All @@ -93,7 +91,9 @@ public void sumNumbers(int max) {
sum = sum + number;
}
}
System.out.println("The Sum of numbers is: " + sum);
if (LOGGER.isLoggable(Level.INFO)) {
LOGGER.info("The Sum of numbers is: " + sum);
}
}

/**
Expand Down